Issue 2138047: code review 2138047: runtime: fix bug in tracebacks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2138047: code review 2138047: runtime: fix bug in tracebacks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by r

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix bug in tracebacks Need to correct for deferproc's extra 2 words of stack or in some cases (such as memory profiling) traceback can cause a crash. Also bulletproof the closure test.

Patch Set 1 #

Patch Set 2 : code review 2138047: runtime: fix bug in tracebacks #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/runtime/amd64/traceback.c	View	1	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-09-09 04:21:40 UTC) #1

14 years, 11 months ago (2010-09-09 04:29:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a6de340ccf3e ***

runtime: fix bug in tracebacks
Need to correct for deferproc's extra 2 words of stack or in some
cases (such as memory profiling) traceback can cause a crash.
Also bulletproof the closure test.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2138047

Expand All Messages | Collapse All Messages