Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 2136041: code review 2136041: test: Match gccgo error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by iant
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

test: Match gccgo error messages. bug284.go:33: error: invalid type conversion bug284.go:36: error: invalid type conversion (cannot use type A2 as type A1) bug284.go:37: error: invalid type conversion bug284.go:38: error: invalid type conversion (cannot use type A1 as type A2) bug284.go:56: error: invalid type conversion bug284.go:59: error: invalid type conversion (cannot use type S2 as type S1) bug284.go:60: error: invalid type conversion bug284.go:61: error: invalid type conversion (cannot use type S1 as type S2) bug284.go:71: error: invalid type conversion bug284.go:74: error: invalid type conversion (cannot use type P2 as type P1) bug284.go:75: error: invalid type conversion bug284.go:76: error: invalid type conversion (cannot use type P1 as type P2) bug284.go:96: error: invalid type conversion bug284.go:99: error: invalid type conversion (cannot use type Q2 as type Q1) bug284.go:101: error: invalid type conversion (cannot use type Q1 as type Q2) bug284.go:111: error: invalid type conversion (different parameter types) bug284.go:114: error: invalid type conversion (different parameter types) bug284.go:115: error: invalid type conversion (different parameter types) bug284.go:116: error: invalid type conversion (different parameter types) bug284.go:134: error: invalid type conversion (incompatible type for method 'f' (different result types)) bug284.go:137: error: invalid type conversion (incompatible type for method 'f' (different result types)) bug284.go:138: error: invalid type conversion (incompatible type for method 'f' (different result types)) bug284.go:139: error: invalid type conversion (incompatible type for method 'f' (different result types)) bug284.go:149: error: invalid type conversion bug284.go:152: error: invalid type conversion (cannot use type L2 as type L1) bug284.go:153: error: invalid type conversion bug284.go:154: error: invalid type conversion (cannot use type L1 as type L2) bug284.go:164: error: invalid type conversion bug284.go:167: error: invalid type conversion (cannot use type L2 as type L1) bug284.go:168: error: invalid type conversion bug284.go:169: error: invalid type conversion (cannot use type L1 as type L2) bug284.go:179: error: invalid type conversion bug284.go:182: error: invalid type conversion (cannot use type C2 as type C1) bug284.go:183: error: invalid type conversion bug284.go:184: error: invalid type conversion (cannot use type C1 as type C2)

Patch Set 1 #

Patch Set 2 : code review 2136041: test: Match gccgo error messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M test/fixedbugs/bug284.go View 9 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-09-02 00:45:01 UTC) #1
rsc
LGTM
14 years, 10 months ago (2010-09-02 01:09:43 UTC) #2
iant
14 years, 10 months ago (2010-09-02 04:05:38 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=006a7bb36e73 ***

test: Match gccgo error messages.

bug284.go:33: error: invalid type conversion
bug284.go:36: error: invalid type conversion (cannot use type A2 as type A1)
bug284.go:37: error: invalid type conversion
bug284.go:38: error: invalid type conversion (cannot use type A1 as type A2)
bug284.go:56: error: invalid type conversion
bug284.go:59: error: invalid type conversion (cannot use type S2 as type S1)
bug284.go:60: error: invalid type conversion
bug284.go:61: error: invalid type conversion (cannot use type S1 as type S2)
bug284.go:71: error: invalid type conversion
bug284.go:74: error: invalid type conversion (cannot use type P2 as type P1)
bug284.go:75: error: invalid type conversion
bug284.go:76: error: invalid type conversion (cannot use type P1 as type P2)
bug284.go:96: error: invalid type conversion
bug284.go:99: error: invalid type conversion (cannot use type Q2 as type Q1)
bug284.go:101: error: invalid type conversion (cannot use type Q1 as type Q2)
bug284.go:111: error: invalid type conversion (different parameter types)
bug284.go:114: error: invalid type conversion (different parameter types)
bug284.go:115: error: invalid type conversion (different parameter types)
bug284.go:116: error: invalid type conversion (different parameter types)
bug284.go:134: error: invalid type conversion (incompatible type for method 'f'
(different result types))
bug284.go:137: error: invalid type conversion (incompatible type for method 'f'
(different result types))
bug284.go:138: error: invalid type conversion (incompatible type for method 'f'
(different result types))
bug284.go:139: error: invalid type conversion (incompatible type for method 'f'
(different result types))
bug284.go:149: error: invalid type conversion
bug284.go:152: error: invalid type conversion (cannot use type L2 as type L1)
bug284.go:153: error: invalid type conversion
bug284.go:154: error: invalid type conversion (cannot use type L1 as type L2)
bug284.go:164: error: invalid type conversion
bug284.go:167: error: invalid type conversion (cannot use type L2 as type L1)
bug284.go:168: error: invalid type conversion
bug284.go:169: error: invalid type conversion (cannot use type L1 as type L2)
bug284.go:179: error: invalid type conversion
bug284.go:182: error: invalid type conversion (cannot use type C2 as type C1)
bug284.go:183: error: invalid type conversion
bug284.go:184: error: invalid type conversion (cannot use type C1 as type C2)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2136041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b