Issue 2132046: code review 2132046: arm: work around reg allocator bug in 5g, in two parts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2132046: code review 2132046: arm: work around reg allocator bug in 5g, in two parts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by r

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

arm: work around reg allocator bug in 5g, in two parts. 1) hack regalloc to leave R9 (m) and R10 (g) alone. the real fix is tricker, but this gets us running 2) fix up the few places in the package sources that the shortage of registers affects, by simplifying some expressions. all of this should be reverted when the right fix is in. Fixes issue 1084.

Patch Set 1 #

Patch Set 2 : code review 2132046: arm: work around reg allocator bug in 5g, in two parts. #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -17 lines)			Patch
M	src/cmd/5g/gsubr.c	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/compress/flate/huffman_bit_writer.go	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/pkg/gob/decode.go	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	src/pkg/log/log.go	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/net/ip.go	View		1 chunk	+10 lines, -4 lines	0 comments	Download
M	src/pkg/time/format.go	View		1 chunk	+11 lines, -5 lines	0 comments	Download
M	src/pkg/xml/xml.go	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-09-11 03:47:55 UTC) #1

14 years, 10 months ago (2010-09-11 03:55:32 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d344fa9b91d4 ***

arm: work around reg allocator bug in 5g, in two parts.
1) hack regalloc to leave R9 (m) and R10 (g) alone.
the real fix is tricker, but this gets us running
2) fix up the few places in the package sources that
the shortage of registers affects, by simplifying
some expressions.

all of this should be reverted when the right fix is in.

Fixes issue 1084.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2132046

Expand All Messages | Collapse All Messages