Issue 2128042: code review 2128042: 9term, win: better echo cancellation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2128042: code review 2128042: 9term, win: better echo cancellation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

9term, win: better echo cancellation Also just drop \r from output. It's a losing battle to keep turning it off.

Patch Set 1 #

Patch Set 2 : code review 2128042: 9term, win: better echo cancellation #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -61 lines)			Patch
M	src/cmd/9term/9term.c	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	src/cmd/9term/SunOS.c	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/cmd/9term/bsdpty.c	View		1 chunk	+0 lines, -23 lines	0 comments	Download
M	src/cmd/9term/rcstart.c	View	1	2 chunks	+70 lines, -2 lines	0 comments	Download
M	src/cmd/9term/term.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/cmd/9term/win.c	View	1	10 chunks	+49 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

14 years, 4 months ago (2010-09-03 14:21:27 UTC) #2

*** Submitted as 55046e95ea4d ***

9term, win: better echo cancellation

Also just drop \r from output.
It's a losing battle to keep turning it off.

R=rsc
http://codereview.appspot.com/2128042

Expand All Messages | Collapse All Messages