Issue 2124046: code review 2124046: goinstall: warn when http:// is found at beginning of p...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2124046: code review 2124046: goinstall: warn when http:// is found at beginning of p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by bytbox

Modified:
14 years, 10 months ago

Reviewers:

CC:
golang-dev, adg1, rsc, adg

Visibility:
Public.

Description

goinstall: warn when http:// is found at beginning of package name Fixes issue 860.

Patch Set 2 : code review 2124046: goinstall: warn when http:// is found at beginning of p... #

Total comments: 2

Patch Set 3 : code review 2124046: goinstall: warn when http:// is found at beginning of p... #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/cmd/goinstall/main.go	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bytbox

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-09-13 00:16:46 UTC) #1

adg1

http://codereview.appspot.com/2124046/diff/2001/src/cmd/goinstall/main.go File src/cmd/goinstall/main.go (right): http://codereview.appspot.com/2124046/diff/2001/src/cmd/goinstall/main.go#newcode151 src/cmd/goinstall/main.go:151: if len(pkg) > 7 && pkg[:7] == "http://" { ...

14 years, 10 months ago (2010-09-13 01:35:17 UTC) #2

bytbox

Hello golang-dev@googlegroups.com, adg1 (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 10 months ago (2010-09-13 01:49:38 UTC) #3

adg

14 years, 10 months ago (2010-09-13 03:00:02 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=e414a7dae354 ***

goinstall: warn when http:// is found at beginning of package name
Fixes issue 860.

R=golang-dev, adg1, rsc, adg
CC=golang-dev
http://codereview.appspot.com/2124046

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages