Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 212045: code review 212045: 8g: respect ullman numbers in float comparison (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by rsc
Modified:
15 years, 3 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

8g: respect ullman numbers in float comparison Fixes issue 602.

Patch Set 1 #

Patch Set 2 : code review 212045: 8g: respect ullman numbers in float comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
M src/cmd/8g/cgen.c View 4 chunks +14 lines, -8 lines 0 comments Download
A test/fixedbugs/bug258.go View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 3 months ago (2010-02-17 23:28:43 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=7b038f40978d *** 8g: respect ullman numbers in float comparison Fixes issue 602. ...
15 years, 3 months ago (2010-02-17 23:28:48 UTC) #2
ken3
15 years, 3 months ago (2010-02-18 00:21:59 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b