Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 2119049: Extend Http Cache key to contain other Image request parameter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by vikaas.arora
Modified:
13 years, 7 months ago
Reviewers:
gagan.goku, jtarrio
CC:
johnfargo, satya3656, cool-shindig-committers_googlegroups.com
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

The existing Http Cache key takes care of the Image request parameters viz resize_h, resize_w, resize_q. There's another critical parameter 'RewriteMimeType' ("rewriteMime") that's used for converting the image format for the rewritten images. This change : - Extends the Http Cache key to take care of the rewrite-MimeType. - Adds to the existing testcase (AbstractHttpCacheTest.java), the case for validating the cache key for existing Image resize parameters (height, width & quality) - Adds another testcase for testing the cahce key for this new Image parameter (rewrite-MimeType).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java View 1 chunk +2 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java View 5 chunks +48 lines, -3 lines 0 comments Download

Messages

Total messages: 8
vikaas.arora
13 years, 7 months ago (2010-09-13 07:20:36 UTC) #1
jtarrio
lgtm
13 years, 7 months ago (2010-09-13 20:31:53 UTC) #2
vikaas.arora
Jacobo - Thanks for the review. I am not shindig-committer. So someone has to take ...
13 years, 7 months ago (2010-09-14 03:31:30 UTC) #3
gagan.goku
Hi Vikas Time to exploit - I mean use my powers :) Lets discuss once ...
13 years, 7 months ago (2010-09-14 03:37:35 UTC) #4
vikaas.arora
Gagan - Thanks for response. You are already in the reviewer/approver list. Thanks, Vikas On ...
13 years, 7 months ago (2010-09-14 03:41:58 UTC) #5
vikaas.arora
Ping ... On Tue, Sep 14, 2010 at 9:11 AM, Vikas Arora <vikaas.arora@gmail.com> wrote: > ...
13 years, 7 months ago (2010-09-15 03:13:22 UTC) #6
gagan.goku
Ran "mvn -e", build looks great, committed as r997830.
13 years, 7 months ago (2010-09-16 16:50:37 UTC) #7
vikaas.arora
13 years, 7 months ago (2010-09-17 03:20:12 UTC) #8
Thanks Gagan for submitting this.

On Thu, Sep 16, 2010 at 10:20 PM,  <gagan.goku@gmail.com> wrote:
> Ran "mvn -e", build looks great, committed as r997830.
>
>
> http://codereview.appspot.com/2119049/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b