Issue 2113041: code review 2113041: http: add PostForm function to post url-encoded key/val...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2113041: code review 2113041: http: add PostForm function to post url-encoded key/val... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by adg

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: add PostForm function to post url-encoded key/value data. This is a common task, so it makes sense to have a helper to do it. (App Engine doesn't like "Transfer-Encoding: chunked" for POST bodies, which is the default for regular Post.)

Patch Set 1 #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
	M	src/pkg/http/client.go	View		2 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-09-01 06:24:11 UTC) #1

adg

14 years, 11 months ago (2010-09-02 00:01:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6099f9445dc8 ***

http: add PostForm function to post url-encoded key/value data.

This is a common task, so it makes sense to have a helper to do it.

(App Engine doesn't like "Transfer-Encoding: chunked" for POST
bodies, which is the default for regular Post.)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2113041

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages