Issue 2112046: code review 2112046: cgo: show preamble gcc errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2112046: code review 2112046: cgo: show preamble gcc errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by ec

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cgo: show preamble gcc errors Fixes issue 1081

Patch Set 2 : code review 2112046: cgo: show preamble gcc errors #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/cmd/cgo/gcc.go	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc1

http://codereview.appspot.com/2112046/diff/1/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/2112046/diff/1/src/cmd/cgo/gcc.go#newcode207 src/cmd/cgo/gcc.go:207: if len(line) > 8 && line[0:8] == "<stdin>:" { ...

14 years, 10 months ago (2010-09-10 17:31:32 UTC) #1

On 2010/09/11 00:32:46, ec wrote: > *** Abandoned *** Ignore this. Deleted the wrong CL

14 years, 10 months ago (2010-09-11 00:36:41 UTC) #3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-09-11 00:46:45 UTC) #4

rsc

14 years, 10 months ago (2010-09-16 17:38:24 UTC) #5

*** Submitted as aba7a17eb41f ***

cgo: show preamble gcc errors

Fixes issue 1081

R=rsc
CC=golang-dev
http://codereview.appspot.com/2112046

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages