Issue 21050043: page-layout: nonstaff lines, follow-up commit 7a60a342

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21050043: page-layout: nonstaff lines, follow-up commit 7a60a342 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Keith

Modified:
10 years, 5 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

page-layout: nonstaff lines, follow-up commit 7a60a342

Patch Set 1 #

Patch Set 2 : more self-consistent #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	input/regression/page-spacing-nonstaff-lines-and-markup.ly	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	lily/page-layout-problem.cc	View	1	3 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Keith

10 years, 5 months ago (2013-11-02 22:29:05 UTC) #1

Make the code for add_prob() consistent with that for add_system()

https://codereview.appspot.com/21050043/diff/20001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

https://codereview.appspot.com/21050043/diff/20001/lily/page-layout-problem.c...
lily/page-layout-problem.cc:666: if (sky)
This case, skyline-spacing of things that are not systems and outside any
system, does not happen with LilyPond defaults.
If I force skyline-spacing of markup, I need the baseline of the markup even
with the lowest line of Lyrics or other 'loose lines' above, to be consistent
with the rule enforced in distribute_loose_lines() that Lyrics of a lower staff
cannot be any higher than Lyrics of a higher staff, even if skylines would allow
interleaving.

Expand All Messages | Collapse All Messages