Issue 2099043: Clarify infinity_f preprocessor definition.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2099043: Clarify infinity_f preprocessor definition. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Graham Percival (old account)

Modified:
13 years, 7 months ago

Reviewers:
carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Clarify infinity_f preprocessor definition. The old code confuses various style programs, including our own fixcc.py (it produces un-compilable code!). In particular: ----- const Real infinity_f = #ifdef ----- which makes gcc unhapy. The new format is easy for style programs to deal with, still compiles, and is IMO just as clear anyway.

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	flower/real.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival (old account)

I have another tiny clarity rewrite for code.

13 years, 7 months ago (2010-09-06 14:06:30 UTC) #1

Carl

LGTM. Anything we can do rationally to get automatic style fixers to work on our ...

13 years, 7 months ago (2010-09-06 14:23:36 UTC) #2

Graham Percival (old account)

13 years, 7 months ago (2010-09-06 14:46:39 UTC) #3

On 2010/09/06 14:23:36, Carl wrote:
> LGTM.

Thanks, pushed.
 

> Anything we can do rationally to get automatic style fixers to work on our
code
> should be done, IMO.

About 2.5 hours of work so far; not bad.  I think I'm about halfway.

Cheers,
- Graham

Expand All Messages | Collapse All Messages