Issue 2098048: code review 2098048: A+C: Kai Backman (individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2098048: code review 2098048: A+C: Kai Backman (individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

A+C: Kai Backman (individual CLA) Just AUTHORS; already in CONTRIBUTORS from work at Google.

Patch Set 1 #

Patch Set 2 : code review 2098048: A+C: Kai Backman (individual CLA) #

Patch Set 3 : code review 2098048: A+C: Kai Backman (individual CLA) #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-09-13 17:47:42 UTC) #1

gri1

LGTM - gri On Mon, Sep 13, 2010 at 10:47 AM, <rsc@golang.org> wrote: > Reviewers: ...

14 years, 9 months ago (2010-09-13 18:14:11 UTC) #2

rsc

14 years, 9 months ago (2010-09-13 19:41:49 UTC) #3

*** Submitted as ff528f5f691d ***

A+C: Kai Backman (individual CLA)

Just AUTHORS; already in CONTRIBUTORS from work at Google.

R=gri
CC=golang-dev
http://codereview.appspot.com/2098048

Expand All Messages | Collapse All Messages