Issue 209042: code review 209042: spec: disallow NUL in source files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 209042: code review 209042: spec: disallow NUL in source files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

spec: disallow NUL in source files

Patch Set 1 #

Patch Set 2 : code review 209042: spec: disallow NUL in source files #

Patch Set 3 : code review 209042: spec: disallow NUL in source files #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	doc/go_spec.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-02-17 00:14:48 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=fc7c972f7414 *** spec: disallow NUL in source files R=r CC=golang-dev http://codereview.appspot.com/209042

15 years, 2 months ago (2010-02-17 00:47:20 UTC) #4

gri

15 years, 2 months ago (2010-02-17 00:54:09 UTC) #6

I disagree with the change on the grounds that this is a change that
has nothing to do with Go but the shortcomings of other tools. That
said, I will not interfere with this any further.
- Robert



On Tue, Feb 16, 2010 at 4:48 PM, Rob 'Commander' Pike <r@google.com> wrote:
> abstains? either he likes it or he doesn't.
>
> LGTM
>
>
>

Expand All Messages | Collapse All Messages