code review 207087: remove assumption that all files belonging to a package...

remove assumption that all files belonging to a package are in the same directory:
- adjust ast.Package node and doc.PackageDoc correspondingly
- introduce parser.ParseFiles

[gri, 2010-02-12 22:15:38]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-02-12 22:36:57]

LGTM

http://codereview.appspot.com/207087/diff/10/14
File src/pkg/go/parser/interface.go (right):

http://codereview.appspot.com/207087/diff/10/14#newcode146
src/pkg/go/parser/interface.go:146: // ParseFileList calls ParseFile for each
file in filenames list and returns
suggest ParseFiles, since the field in Package is Files.

in contrast to ParseExprList, ParseStmtList,
FileList is not a grammar term.

[gri, 2010-02-12 22:50:26]

Done.

Will need to submit with the pending godoc changes (after review)
since this CL requires some changes to godoc's package.html template.
- Robert

On Fri, Feb 12, 2010 at 2:36 PM,  <rsc@golang.org> wrote:
> LGTM
>
>
>
> http://codereview.appspot.com/207087/diff/10/14
> File src/pkg/go/parser/interface.go (right):
>
> http://codereview.appspot.com/207087/diff/10/14#newcode146
> src/pkg/go/parser/interface.go:146: // ParseFileList calls ParseFile for
> each file in filenames list and returns
> suggest ParseFiles, since the field in Package is Files.
>
> in contrast to ParseExprList, ParseStmtList,
> FileList is not a grammar term.
>
> http://codereview.appspot.com/207087/show
>

[gri, 2010-02-16 19:20:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=c1a627ac3676 ***

remove assumption that all files belonging to a package are in the same
directory:
- adjust ast.Package node and doc.PackageDoc correspondingly
- introduce parser.ParseFiles

R=rsc
CC=golang-dev
http://codereview.appspot.com/207087