Issue 2040043: code review 2040043: test: gccgo and gc print the error on different lines.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2040043: code review 2040043: test: gccgo and gc print the error on different lines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by iant

Modified:
15 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

test: gccgo and gc print the error on different lines. This introduces GC_ERROR to mark an error only issued by the gc compiler. GCCGO_ERROR already exists to mark errors only issued by the gccgo compiler. Obviously these should be used sparingly. bug195.go:9: error: interface contains embedded non-interface bug195.go:12: error: interface contains embedded non-interface bug195.go:15: error: interface contains embedded non-interface bug195.go:18: error: invalid recursive interface bug195.go:22: error: invalid recursive interface

Patch Set 1 #

Patch Set 2 : code review 2040043: test: gccgo and gc print the error on different lines. #

Patch Set 3 : code review 2040043: test: gccgo and gc print the error on different lines. #

Patch Set 4 : code review 2040043: test: gccgo and gc print the error on different lines. #

Total comments: 1

Patch Set 5 : code review 2040043: test: gccgo and gc print the error on different lines. #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	test/errchk	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/fixedbugs/bug195.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 7 months ago (2010-08-31 20:49:11 UTC) #1

iant

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 7 months ago (2010-08-31 20:50:25 UTC) #2

rsc1

LGTM http://codereview.appspot.com/2040043/diff/7001/8001 File test/errchk (right): http://codereview.appspot.com/2040043/diff/7001/8001#newcode63 test/errchk:63: next unless $src =~ m|// ERROR (.*)| || ...

15 years, 7 months ago (2010-08-31 20:54:49 UTC) #3

iant

15 years, 7 months ago (2010-08-31 21:12:28 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=27d6804e03f9 ***

test: gccgo and gc print the error on different lines.

This introduces GC_ERROR to mark an error only issued by the
gc compiler.  GCCGO_ERROR already exists to mark errors only
issued by the gccgo compiler.  Obviously these should be used
sparingly.

bug195.go:9: error: interface contains embedded non-interface
bug195.go:12: error: interface contains embedded non-interface
bug195.go:15: error: interface contains embedded non-interface
bug195.go:18: error: invalid recursive interface
bug195.go:22: error: invalid recursive interface

R=rsc
CC=golang-dev
http://codereview.appspot.com/2040043

Expand All Messages | Collapse All Messages