code review 203050: Added header-key sorting in http.Request/Response befor...

Added header-key sorting in http.Request/Response before writing to wire.

[petar-m, 2010-02-06 02:01:49]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-02-06 02:10:02]

http://codereview.appspot.com/203050/diff/1003/4
File src/pkg/http/request.go (right):

http://codereview.appspot.com/203050/diff/1003/4#newcode52
src/pkg/http/request.go:52: var (
Unparenthesize.

http://codereview.appspot.com/203050/diff/1003/5
File src/pkg/http/response.go (right):

http://codereview.appspot.com/203050/diff/1003/5#newcode18
src/pkg/http/response.go:18: var (
Unparenthesize.

http://codereview.appspot.com/203050/diff/1003/5#newcode498
src/pkg/http/response.go:498: type keyValue struct {
If you build a var lines []string with the full key+": "+value+"\r\n", you can
sort.SortStrings(lines) and
not need to worry about defining a new type 
and methods here.

[petar-m, 2010-02-06 02:21:21]

One question.

http://codereview.appspot.com/203050/diff/1003/4
File src/pkg/http/request.go (right):

http://codereview.appspot.com/203050/diff/1003/4#newcode52
src/pkg/http/request.go:52: var (
On 2010/02/06 02:10:02, rsc wrote:
> Unparenthesize.

Done.

http://codereview.appspot.com/203050/diff/1003/5
File src/pkg/http/response.go (right):

http://codereview.appspot.com/203050/diff/1003/5#newcode18
src/pkg/http/response.go:18: var (
On 2010/02/06 02:10:02, rsc wrote:
> Unparenthesize.
> 

Done.

http://codereview.appspot.com/203050/diff/1003/5#newcode498
src/pkg/http/response.go:498: type keyValue struct {
What you are proposing would have:

Accept-Language:
Accept:

vs.  what I've written has:

Accept:
Accept-Language:

Which do we want?

On 2010/02/06 02:10:02, rsc wrote:
> If you build a var lines []string with the full key+": "+value+"\r\n", you can
> sort.SortStrings(lines) and
> not need to worry about defining a new type 
> and methods here.
>

[rsc, 2010-02-06 02:23:02]

> What you are proposing would have:
>
> Accept-Language:
> Accept:
>
> vs.  what I've written has:
>
> Accept:
> Accept-Language:
>
> Which do we want?

Does it matter?  I thought we just wanted to be
self-consistent.  There's no actual requirement on the
header line order, is there?

Russ

[petar_csail.mit.edu, 2010-02-06 02:27:38]

I don't think there is. Ok, we'll go the simpler way.

On Fri, Feb 5, 2010 at 9:22 PM, Russ Cox <rsc@golang.org> wrote:
>> What you are proposing would have:
>>
>> Accept-Language:
>> Accept:
>>
>> vs.  what I've written has:
>>
>> Accept:
>> Accept-Language:
>>
>> Which do we want?
>
> Does it matter?  I thought we just wanted to be
> self-consistent.  There's no actual requirement on the
> header line order, is there?
>
> Russ
>

[petar-m, 2010-02-06 02:29:24]

Uploaded CL.

On 2010/02/06 02:27:38, petar_csail.mit.edu wrote:
> I don't think there is. Ok, we'll go the simpler way.
> 
> On Fri, Feb 5, 2010 at 9:22 PM, Russ Cox
<https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=rsc@golang.org> wrote:
> >> What you are proposing would have:
> >>
> >> Accept-Language:
> >> Accept:
> >>
> >> vs. &nbsp;what I've written has:
> >>
> >> Accept:
> >> Accept-Language:
> >>
> >> Which do we want?
> >
> > Does it matter? &nbsp;I thought we just wanted to be
> > self-consistent. &nbsp;There's no actual requirement on the
> > header line order, is there?
> >
> > Russ
> >
>

[rsc, 2010-02-06 02:30:55]

LGTM

[rsc, 2010-02-06 02:32:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=311e90c0b8ba ***

http: sort header keys when writing Response or Request to wire

R=rsc
CC=golang-dev
http://codereview.appspot.com/203050

Committer: Russ Cox <rsc@golang.org>