Issue 2023043: code review 2023043: Sync from internal version.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2023043: code review 2023043: Sync from internal version. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by dsymonds

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

Sync from internal version. - fix nil Marshaler fields - fix text encoding of nil

Patch Set 1 #

Patch Set 2 : code review 2023043: Sync from internal version. #

Patch Set 3 : code review 2023043: Sync from internal version. #

Patch Set 4 : code review 2023043: Sync from internal version. #

Patch Set 5 : code review 2023043: Sync from internal version. #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
M	proto/all_test.go	View	1 2 3	3 chunks	+43 lines, -1 line	0 comments	Download
M	proto/encode.go	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	proto/text.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-08-26 00:12:44 UTC) #1

LGTM i blew up yesterday trying to put together an identical CL

14 years, 11 months ago (2010-08-26 00:14:01 UTC) #2

dsymonds

14 years, 11 months ago (2010-08-26 04:27:18 UTC) #5

*** Submitted as a1d87f2568f0 ***

	Sync from internal version.
          - fix nil Marshaler fields
          - fix text encoding of nil

R=r
CC=golang-dev
http://codereview.appspot.com/2023043

Expand All Messages | Collapse All Messages