code review 202051: FreeBSD: Kill only takes pid & signal

FreeBSD: Kill only takes pid & signal

Cosmetic fix.  The FreeBSD system call only takes two
arguments.

http://fxr.watson.org/fxr/source/kern/kern_sig.c?im=bigexcerpts#L1678

[cw, 2010-02-04 17:55:00]

Hello dho, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[dho, 2010-02-04 17:56:18]

On 2010/02/04 17:55:00, cw wrote:
> Hello dho, rsc (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change.

LGTM. There may be more of these; the file is largely copied from darwin, and I
didn't (and haven't) had the time to do line-by-line reviews.

--dho

[cw, 2010-02-04 17:59:17]

On Thu, Feb 04, 2010 at 05:56:18PM +0000, devon.odell@gmail.com wrote:

> LGTM. There may be more of these; the file is largely copied from
> darwin, and I didn't (and haven't) had the time to do line-by-line
> reviews.

I think fixing them one by one makes the most sense at this point in
case we accidentally cause regressions.

[rsc, 2010-02-04 19:22:51]

LGTM

If you are interested in pushing this further it should be
not too hard to pull out the number of arguments being
passed in each FreeBSD //sys line and compare that to
the signatures in zsyscall_freebsd_*.go.

Russ

[rsc, 2010-02-04 21:08:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=0ca35b6e416b ***

FreeBSD: Kill only takes pid & signal

Cosmetic fix.  The FreeBSD system call only takes two
arguments.

http://fxr.watson.org/fxr/source/kern/kern_sig.c?im=bigexcerpts#L1678

R=dho, rsc
CC=golang-dev
http://codereview.appspot.com/202051

Committer: Russ Cox <rsc@golang.org>