code review 2020045: codereview: print status when hung

codereview: print status when hung

After 30 seconds, start printing status updates,
so that we can see whether hg is making progress.

$ hg upload 1983051
Thu Aug 26 15:06:15 2010 running gofmt
Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go
Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go
Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go
Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go
Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go
Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go
Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go
Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go
Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go
Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go
Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go
Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go
Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go
Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go
Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go
Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go
Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go
http://codereview.appspot.com/1983051

$

[rsc, 2010-08-26 19:13:54]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-08-26 19:34:28]

LGTM

http://codereview.appspot.com/2020045/diff/2001/3001
File lib/codereview/codereview.py (right):

http://codereview.appspot.com/2020045/diff/2001/3001#newcode266
lib/codereview/codereview.py:266: set_status("uploading CL metadata + diffs")
should this be "uploaded CL..."?

http://codereview.appspot.com/2020045/diff/2001/3001#newcode396
lib/codereview/codereview.py:396: set_status("Loading CL " + name)
all the other messages start lower-case

http://codereview.appspot.com/2020045/diff/2001/3001#newcode430
lib/codereview/codereview.py:430: set_status("Loaded CL " + name)
all the other messages start lower-case

http://codereview.appspot.com/2020045/diff/2001/3001#newcode436
lib/codereview/codereview.py:436: # print >>sys.stderr, "\t", time.asctime(), s
debugging left-over?

[rsc, 2010-08-26 20:27:03]

> http://codereview.appspot.com/2020045/diff/2001/3001#newcode266
> lib/codereview/codereview.py:266: set_status("uploading CL metadata +
> diffs")
> should this be "uploaded CL..."?

Yes.

> http://codereview.appspot.com/2020045/diff/2001/3001#newcode396
> lib/codereview/codereview.py:396: set_status("Loading CL " + name)
> all the other messages start lower-case
>
> http://codereview.appspot.com/2020045/diff/2001/3001#newcode430
> lib/codereview/codereview.py:430: set_status("Loaded CL " + name)
> all the other messages start lower-case

Done, done.

> http://codereview.appspot.com/2020045/diff/2001/3001#newcode436
> lib/codereview/codereview.py:436: # print >>sys.stderr, "\t",
> time.asctime(), s
> debugging left-over?

Yes but commented out for future debugging.  ;-)

Russ

[rsc, 2010-08-26 20:27:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=a2254712c2c8 ***

codereview: print status when hung

After 30 seconds, start printing status updates,
so that we can see whether hg is making progress.

$ hg upload 1983051
Thu Aug 26 15:06:15 2010 running gofmt
Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go
Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go
Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go
Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go
Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go
Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go
Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go
Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go
Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go
Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go
Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go
Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go
Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go
Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go
Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go
Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go
Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go
http://codereview.appspot.com/1983051

$

R=gri
CC=golang-dev
http://codereview.appspot.com/2020045