code review 2020044: freetype-go: Fix panic when drawing a span to the right...

freetype-go: Fix panic when drawing a span to the right of the
bounding rect.

This bug was introduced when an image.RGBA's representation went from
slice of slices to one linear buffer.

[nigeltao, 2010-08-26 07:59:24]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-08-26 09:04:52]

Lgtm

On Thursday, August 26, 2010,  <nigeltao@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> freetype-go: Fix panic when drawing a span to the right of the
> bounding rect.
>
> This bug was introduced when an image.RGBA's representation went from
> slice of slices to one linear buffer.
>
> Please review this at http://codereview.appspot.com/2020044/
>
> Affected files:
>   M freetype/raster/paint.go
>
>
> Index: freetype/raster/paint.go
> ===================================================================
> --- a/freetype/raster/paint.go
> +++ b/freetype/raster/paint.go
> @@ -105,6 +105,9 @@
>                 if s.X1 > b.Max.X {
>                         s.X1 = b.Max.X
>                 }
> +               if s.X0 >= s.X1 {
> +                       continue
> +               }
>                 base := s.Y * r.Image.Stride
>                 p := r.Image.Pix[base+s.X0 : base+s.X1]
>                 for i, rgba := range p {
>
>
>

[nigeltao, 2010-08-27 00:51:23]

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=7329234544aa ***

freetype-go: Fix panic when drawing a span to the right of the
bounding rect.

This bug was introduced when an image.RGBA's representation went from
slice of slices to one linear buffer.

R=r
CC=golang-dev
http://codereview.appspot.com/2020044