Issue 2005044: code review 2005044: update Makefiles for new scheme

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2005044: code review 2005044: update Makefiles for new scheme (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by r

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

update Makefiles for new scheme

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	Make.protobuf	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/descriptor/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/generator/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/plugin/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/testdata/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/testdata/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-08-25 12:43:26 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-08-25 12:43:56 UTC) #2

14 years, 11 months ago (2010-08-25 21:39:32 UTC) #4

*** Submitted as 406d88f5cb64 ***

update Makefiles for new scheme

R=rsc
CC=golang-dev
http://codereview.appspot.com/2005044