code review 199066: bug252: make ... vs ...T crossing an error, at least for now

bug252: make ... vs ...T crossing an error, at least for now

[rsc, 2010-02-02 22:36:56]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-02-02 22:55:21]

LGTM

On Feb 3, 2010, at 9:36 AM, rsc@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> bug252: make ... vs ...T crossing an error, at least for now
>
> Please review this at http://codereview.appspot.com/199066/show
>
> Affected files:
>  M src/cmd/gc/typecheck.c
>  A test/fixedbugs/bug252.go
>
>
> Index: src/cmd/gc/typecheck.c
> ===================================================================
> --- a/src/cmd/gc/typecheck.c
> +++ b/src/cmd/gc/typecheck.c
> @@ -1517,6 +1517,11 @@
> 	for(tl=tstruct->type; tl; tl=tl->down) {
> 		t = tl->type;
> 		if(tl->isddd) {
> +			if(nl != nil && nl->n->isddd && !eqtype(nl->n->type, t)) {
> +				// TODO(rsc): This is not actually illegal but will
> +				// help catch bugs.
> +				yyerror("cannot pass %+N as %T (... mismatch)", nl->n, tl);
> +			}
> 			if(nl != nil && nl->next == nil && nl->n->isddd && eqtype(nl->n- 
> >type, t))
> 				goto out;
> 			for(; nl; nl=nl->next) {
> Index: test/fixedbugs/bug252.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug252.go
> @@ -0,0 +1,15 @@
> +// errchk $G $D/$F.go
> +
> +// Copyright 2010 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package main
> +
> +func f(args ...) {
> +	g(args)	// ERROR "[.][.][.] mismatch"
> +}
> +
> +func g(args ...interface{}) {
> +	f(args)	// ERROR "[.][.][.] mismatch"
> +}
>
>

[rsc, 2010-02-02 23:00:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=2ced4046a96c ***

bug252: make ... vs ...T crossing an error, at least for now

R=r
CC=golang-dev
http://codereview.appspot.com/199066