Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(599)

Issue 199044: code review 199044: Match gccgo error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by iant
Modified:
15 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Match gccgo error messages. I have to admit that "cannot use type p.T as type p.T" is a bit weak. 8g gives a similar error ("cannot use v1 (type p.T) as type p.T in assignment"). bug3.go:37:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:38:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:43:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:44:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:49:5: error: incompatible types in assignment (cannot use type p.T as type p.T) bug3.go:50:5: error: incompatible types in assignment (cannot use type p.T as type p.T) bug3.go:55:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:56:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:57:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:58:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:59:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:60:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:61:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:62:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types))

Patch Set 1 #

Patch Set 2 : code review 199044: Match gccgo error messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M test/fixedbugs/bug248.dir/bug3.go View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 5 months ago (2010-02-02 00:04:47 UTC) #1
rsc
LGTM
15 years, 5 months ago (2010-02-02 00:11:04 UTC) #2
iant
15 years, 5 months ago (2010-02-02 00:26:00 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=0235007e4873 ***

Match gccgo error messages.

I have to admit that "cannot use type p.T as type p.T" is a
bit weak.  8g gives a similar error ("cannot use v1 (type p.T)
as type p.T in assignment").

bug3.go:37:5: error: incompatible type in initialization (incompatible type for
method ‘M’ (different parameter types))
bug3.go:38:5: error: incompatible type in initialization (incompatible type for
method ‘M’ (different parameter types))
bug3.go:43:5: error: incompatible type in initialization (incompatible type for
method ‘M’ (different parameter types))
bug3.go:44:5: error: incompatible type in initialization (incompatible type for
method ‘M’ (different parameter types))
bug3.go:49:5: error: incompatible types in assignment (cannot use type p.T as
type p.T)
bug3.go:50:5: error: incompatible types in assignment (cannot use type p.T as
type p.T)
bug3.go:55:5: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:56:5: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:57:6: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:58:6: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:59:5: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:60:5: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:61:6: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))
bug3.go:62:6: error: incompatible types in assignment (incompatible type for
method ‘M’ (different parameter types))

R=rsc
CC=golang-dev
http://codereview.appspot.com/199044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b