Issue 1989044: code review 1989044: freetype-go: fix Makefiles.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1989044: code review 1989044: freetype-go: fix Makefiles. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by nigeltao

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

freetype-go: fix Makefiles.

Patch Set 1 #

Patch Set 2 : code review 1989044: freetype-go: fix Makefiles. #

Patch Set 3 : code review 1989044: freetype-go: fix Makefiles. #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	freetype/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	freetype/raster/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	freetype/truetype/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-08-25 23:34:45 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/freetype-go/source/detail?r=10d83347ad34 *** freetype-go: fix Makefiles. R=rsc CC=golang-dev http://codereview.appspot.com/1989044

14 years, 4 months ago (2010-08-25 23:47:33 UTC) #4

adg1

14 years, 4 months ago (2010-08-25 23:48:10 UTC) #5

LGTM

On 26 August 2010 09:34,  <nigeltao@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> freetype-go: fix Makefiles.
>
> Please review this at http://codereview.appspot.com/1989044/
>
> Affected files:
>  M Makefile
>  M freetype/Makefile
>  M freetype/raster/Makefile
>  M freetype/truetype/Makefile
>
>
> Index: Makefile
> ===================================================================
> --- a/Makefile
> +++ b/Makefile
> @@ -3,7 +3,7 @@
>  # FreeType License or the GNU General Public License version 2 (or
>  # any later version), both of which can be found in the LICENSE file.
>
> -include $(GOROOT)/src/Make.$(GOARCH)
> +include $(GOROOT)/src/Make.inc
>
>  all:   install
>
> Index: freetype/Makefile
> ===================================================================
> --- a/freetype/Makefile
> +++ b/freetype/Makefile
> @@ -3,7 +3,7 @@
>  # FreeType License or the GNU General Public License version 2 (or
>  # any later version), both of which can be found in the LICENSE file.
>
> -include $(GOROOT)/src/Make.$(GOARCH)
> +include $(GOROOT)/src/Make.inc
>
>  TARG=freetype-go.googlecode.com/hg/freetype
>  GOFILES=\
> Index: freetype/raster/Makefile
> ===================================================================
> --- a/freetype/raster/Makefile
> +++ b/freetype/raster/Makefile
> @@ -3,7 +3,7 @@
>  # FreeType License or the GNU General Public License version 2 (or
>  # any later version), both of which can be found in the LICENSE file.
>
> -include $(GOROOT)/src/Make.$(GOARCH)
> +include $(GOROOT)/src/Make.inc
>
>  TARG=freetype-go.googlecode.com/hg/freetype/raster
>  GOFILES=\
> Index: freetype/truetype/Makefile
> ===================================================================
> --- a/freetype/truetype/Makefile
> +++ b/freetype/truetype/Makefile
> @@ -3,7 +3,7 @@
>  # FreeType License or the GNU General Public License version 2 (or
>  # any later version), both of which can be found in the LICENSE file.
>
> -include $(GOROOT)/src/Make.$(GOARCH)
> +include $(GOROOT)/src/Make.inc
>
>  TARG=freetype-go.googlecode.com/hg/freetype/truetype
>  GOFILES=\
>
>
>

Expand All Messages | Collapse All Messages