Issue 1983043: code review 1983043: update the tree to use the new regexp methods

Issue 1983043: code review 1983043: update the tree to use the new regexp methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by r

Modified:
14 years, 11 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

update the tree to use the new regexp methods

Patch Set 2 : code review 1983043: update the tree to use the new regexp methods #

Total comments: 6

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	src/cmd/godoc/codewalk.go	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	src/cmd/godoc/godoc.go	View	1 chunk	+1 line, -1 line	2 comments	Download
M	src/cmd/goinstall/download.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/go/doc/comment.go	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	src/pkg/go/doc/doc.go	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/pkg/mime/multipart/multipart.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/bench/regex-dna.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/bench/regex-dna-parallel.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-08-12 06:40:31 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=71176fa999ce *** update the tree to use the new regexp methods R=rsc ...

14 years, 11 months ago (2010-08-12 06:48:49 UTC) #3

gri

This CL breaks godoc. Fix forthcoming. http://codereview.appspot.com/1983043/diff/4001/5001 File src/cmd/godoc/codewalk.go (right): http://codereview.appspot.com/1983043/diff/4001/5001#newcode455 src/cmd/godoc/codewalk.go:455: if len(m) > ...

14 years, 11 months ago (2010-08-12 17:11:44 UTC) #4

rsc1

14 years, 11 months ago (2010-08-12 18:21:09 UTC) #5

http://codereview.appspot.com/1983043/diff/4001/5002
File src/cmd/godoc/godoc.go (right):

http://codereview.appspot.com/1983043/diff/4001/5002#newcode946
src/cmd/godoc/godoc.go:946: m := rx.Find(src)
On 2010/08/12 17:11:45, gri wrote:
> This is wrong. It should be FindAllIndex.

I think you mean FindSubmatchIndex.
But instead could be FindSubmatch and
then use string(m[1]) below.

http://codereview.appspot.com/1983043/diff/4001/5004
File src/pkg/go/doc/comment.go (right):

http://codereview.appspot.com/1983043/diff/4001/5004#newcode202
src/pkg/go/doc/comment.go:202: m := matchRx.Find(line)
On 2010/08/12 17:11:45, gri wrote:
> This is wrong. It should be FindAllIndex.

FindSubmatchIndex.

Expand All Messages | Collapse All Messages