Issue 1982049: code review 1982049: build: $GOBIN defaults to $GOROOT/bin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1982049: code review 1982049: build: $GOBIN defaults to $GOROOT/bin (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

build: $GOBIN defaults to $GOROOT/bin

Patch Set 1 #

Patch Set 2 : code review 1982049: build: $GOBIN defaults to $GOROOT/bin #

Patch Set 3 : code review 1982049: build: $GOBIN defaults to $GOROOT/bin #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -438 lines)			Patch
A	bin/~place-holder~	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	src/Make.ccmd	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	src/Make.cmd	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/Make.common	View		1 chunk	+0 lines, -17 lines	0 comments	Download
R	src/Make.conf	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	src/Make.inc	View		3 chunks	+25 lines, -4 lines	0 comments	Download
M	src/Make.pkg	View		7 chunks	+15 lines, -21 lines	0 comments	Download
M	src/all.bash	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/5a/Makefile	View		2 chunks	+4 lines, -18 lines	0 comments	Download
M	src/cmd/5c/Makefile	View		2 chunks	+6 lines, -15 lines	0 comments	Download
M	src/cmd/5g/Makefile	View		2 chunks	+7 lines, -13 lines	0 comments	Download
M	src/cmd/5l/Makefile	View		2 chunks	+6 lines, -13 lines	0 comments	Download
M	src/cmd/6a/Makefile	View		2 chunks	+4 lines, -19 lines	0 comments	Download
M	src/cmd/6c/Makefile	View		2 chunks	+6 lines, -15 lines	0 comments	Download
M	src/cmd/6g/Makefile	View		2 chunks	+6 lines, -15 lines	0 comments	Download
M	src/cmd/6l/Makefile	View		2 chunks	+6 lines, -13 lines	0 comments	Download
M	src/cmd/8a/Makefile	View		2 chunks	+4 lines, -19 lines	0 comments	Download
M	src/cmd/8c/Makefile	View		2 chunks	+6 lines, -15 lines	0 comments	Download
M	src/cmd/8g/Makefile	View		2 chunks	+6 lines, -15 lines	0 comments	Download
M	src/cmd/8l/Makefile	View		2 chunks	+6 lines, -13 lines	0 comments	Download
M	src/cmd/cc/Makefile	View		2 chunks	+5 lines, -16 lines	0 comments	Download
M	src/cmd/clean.bash	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/cmd/cov/Makefile	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	src/cmd/ebnflint/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/Makefile	View		3 chunks	+7 lines, -16 lines	0 comments	Download
M	src/cmd/gc/mkbuiltin	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/cmd/godefs/Makefile	View		2 chunks	+3 lines, -11 lines	0 comments	Download
M	src/cmd/gofmt/test.sh	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/cmd/goinstall/main.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gopack/Makefile	View		1 chunk	+5 lines, -8 lines	0 comments	Download
M	src/cmd/gotest/Makefile	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/cmd/gotest/gotest	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/make.bash	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/cmd/nm/Makefile	View		1 chunk	+6 lines, -12 lines	0 comments	Download
M	src/cmd/prof/Makefile	View		3 chunks	+6 lines, -11 lines	0 comments	Download
M	src/env.bash	View	1	3 chunks	+11 lines, -16 lines	0 comments	Download
M	src/lib9/Makefile	View		2 chunks	+9 lines, -29 lines	0 comments	Download
M	src/libbio/Makefile	View		2 chunks	+3 lines, -17 lines	0 comments	Download
M	src/libmach/Makefile	View		2 chunks	+3 lines, -15 lines	0 comments	Download
M	src/make.bash	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/run.bash	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-08-24 17:31:35 UTC) #1

rsc

14 years, 8 months ago (2010-08-25 00:00:40 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=859de5c53ba8 ***

build: $GOBIN defaults to $GOROOT/bin

R=r
CC=golang-dev
http://codereview.appspot.com/1982049

Expand All Messages | Collapse All Messages