code review 198066: Add named colors (e.g. image.Blue), suitable for exp/draw.

Add named colors (e.g. image.Blue), suitable for exp/draw.

[nigeltao, 2010-02-02 12:26:41]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-02-02 12:37:26]

http://codereview.appspot.com/198066/diff/4/1004
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/4/1004#newcode24
src/pkg/image/names.go:24: White   ColorImage = ColorImage{RGBAColor{0xff, 0xff,
0xff, 0xff}}
stuttering. you can drop the first ColorImage on each line.

http://codereview.appspot.com/198066/diff/4/1004#newcode28
src/pkg/image/names.go:28: // Synonyms for some of the above colors.
above is not an adjective.
colors above not above colors.
or better: colors listed above.
or best of all (because who knows how godoc will present them): the colors

http://codereview.appspot.com/198066/diff/4/1004#newcode34
src/pkg/image/names.go:34: // A ColorImage is a practically infinite sized Image
that is a solid fill of a Color.
s/infinite sized/infinite-sized/ (hyphen makes it an adjective)

[rsc1, 2010-02-02 18:05:40]

http://codereview.appspot.com/198066/diff/4/1004
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/4/1004#newcode28
src/pkg/image/names.go:28: // Synonyms for some of the above colors.
Are these names from HTML 4.01?  If so, move up into above block.  If not, say
that.

// ... colors above.  Not in HTML 4.01.

http://codereview.appspot.com/198066/diff/4/1004#newcode30
src/pkg/image/names.go:30: Cyan    ColorImage = ColorImage{RGBAColor{0x00, 0xff,
0xff, 0xff}}
Cyan = Aqua
Magenta = Fuschia

[nigeltao, 2010-02-02 20:46:13]

http://codereview.appspot.com/198066/diff/4/1004
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/4/1004#newcode24
src/pkg/image/names.go:24: White   ColorImage = ColorImage{RGBAColor{0xff, 0xff,
0xff, 0xff}}
On 2010/02/02 12:37:26, r wrote:
> stuttering. you can drop the first ColorImage on each line.

Done.

http://codereview.appspot.com/198066/diff/4/1004#newcode28
src/pkg/image/names.go:28: // Synonyms for some of the above colors.
On 2010/02/02 12:37:26, r wrote:
> above is not an adjective.
> colors above not above colors.
> or better: colors listed above.
> or best of all (because who knows how godoc will present them): the colors

Done.

http://codereview.appspot.com/198066/diff/4/1004#newcode28
src/pkg/image/names.go:28: // Synonyms for some of the above colors.
On 2010/02/02 18:05:41, rsc1 wrote:
> Are these names from HTML 4.01?  If so, move up into above block.  If not, say
> that.
> 
> // ... colors above.  Not in HTML 4.01.
> 
> 

Done.

http://codereview.appspot.com/198066/diff/4/1004#newcode30
src/pkg/image/names.go:30: Cyan    ColorImage = ColorImage{RGBAColor{0x00, 0xff,
0xff, 0xff}}
On 2010/02/02 18:05:41, rsc1 wrote:
> Cyan = Aqua
> Magenta = Fuschia
> 

Done.

http://codereview.appspot.com/198066/diff/4/1004#newcode34
src/pkg/image/names.go:34: // A ColorImage is a practically infinite sized Image
that is a solid fill of a Color.
On 2010/02/02 12:37:26, r wrote:
> s/infinite sized/infinite-sized/ (hyphen makes it an adjective)

Done.

[r, 2010-02-03 00:07:51]

http://codereview.appspot.com/198066/diff/8/10
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/8/10#newcode28
src/pkg/image/names.go:28: // Synonyms for some of the HTML 4.01 colors. These
names are not in HTML 4.01.
you should probably put these in the upper var list, along with the comment to
break the list. that will work better in godoc i think.  you can reduce the
number of appearances of HTML 4.01 by one or maybe two then.

[nigeltao, 2010-02-03 11:45:58]

http://codereview.appspot.com/198066/diff/8/10
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/8/10#newcode28
src/pkg/image/names.go:28: // Synonyms for some of the HTML 4.01 colors. These
names are not in HTML 4.01.
On 2010/02/03 00:07:51, r wrote:
> you should probably put these in the upper var list, along with the comment to
> break the list. that will work better in godoc i think.  you can reduce the
> number of appearances of HTML 4.01 by one or maybe two then.

Done.

[r, 2010-02-03 11:51:19]

LGTM

http://codereview.appspot.com/198066/diff/15/1011
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/15/1011#newcode7
src/pkg/image/names.go:7: // Colors named after the HTML 4.01 specification:
http://www.w3.org/TR/REC-html40/types.html#h-6.5
s/named after/from/

[rsc, 2010-02-04 07:31:56]

LGTM

http://codereview.appspot.com/198066/diff/15/1011
File src/pkg/image/names.go (right):

http://codereview.appspot.com/198066/diff/15/1011#newcode27
src/pkg/image/names.go:27: // Synonyms for some of those colors. These synonyms
are not in HTML 4.01.
// These synonyms are not in HTML 4.01.

[nigeltao, 2010-02-04 09:25:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=61bfeb525543 ***

Add named colors (e.g. image.Blue), suitable for exp/draw.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/198066