code review 1976045: Add debug/pe and cgo windows version.

Add debug/pe and cgo windows version.

[vcc, 2010-08-17 08:55:03]

Hello rsc, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, vcc),

I'd like you to review this change.

[rsc, 2010-08-17 16:01:21]

looks like you need to run "hg file 1976045 list-of-files-for-this-CL".

Russ

On Tue, Aug 17, 2010 at 01:55,  <vcc.163@gmail.com> wrote:
> Reviewers: rsc, golang-dev_googlegroups.com,
>
> Message:
> Hello rsc, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
> vcc),
>
> I'd like you to review this change.
>
>
> Description:
> Add debug/pe and cgo windows version.
>
> Please review this at http://codereview.appspot.com/1976045/
>
> Affected files:
>  ~rietveld~placeholder~
>
>
> Index: ~rietveld~placeholder~
> ===================================================================
> diff --git a/~rietveld~placeholder~ b/~rietveld~placeholder~
> new file mode 100644
>
>
>

[vcc, 2010-08-18 05:43:57]

Files:
    src/cmd/cgo/gcc.go
    src/cmd/cgo/out.go
    src/pkg/Makefile
    src/pkg/debug/pe/Makefile
    src/pkg/debug/pe/file.go
    src/pkg/debug/pe/file_test.go
    src/pkg/debug/pe/pe.go
    src/pkg/debug/pe/testdata/gcc-386-mingw-exec
    src/pkg/debug/pe/testdata/gcc-386-mingw-obj
    src/pkg/debug/pe/testdata/hello.c

Note: to run cgo need apply my another CL 1910041 fix ForkExec.

Wei guangjing

2010/8/18 Russ Cox <rsc@golang.org>

> looks like you need to run "hg file 1976045 list-of-files-for-this-CL".
>
> Russ
>
> On Tue, Aug 17, 2010 at 01:55,  <vcc.163@gmail.com> wrote:
> > Reviewers: rsc, golang-dev_googlegroups.com,
> >
> > Message:
> > Hello rsc, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
> > vcc),
> >
> > I'd like you to review this change.
> >
> >
> > Description:
> > Add debug/pe and cgo windows version.
> >
> > Please review this at http://codereview.appspot.com/1976045/
> >
> > Affected files:
> >  ~rietveld~placeholder~
> >
> >
> > Index: ~rietveld~placeholder~
> > ===================================================================
> > diff --git a/~rietveld~placeholder~ b/~rietveld~placeholder~
> > new file mode 100644
> >
> >
> >
>

[rsc1, 2010-08-26 16:31:34]

This looks pretty good when I view the raw patch
but Rietveld can't seem to show me side-by-side diffs.
Could you try "hg upload" again?

Also there are some lingering Mach-O references
in the PE file.

The PE doc comment should explain what PE means
PE (Microsoft Windows Portable Executable).

[vcc, 2010-08-31 03:29:00]

Done, please take another look.

On 2010/08/26 16:31:34, rsc1 wrote:
> This looks pretty good when I view the raw patch
> but Rietveld can't seem to show me side-by-side diffs.
> Could you try "hg upload" again?
> 
> Also there are some lingering Mach-O references
> in the PE file.
> 
> The PE doc comment should explain what PE means
> PE (Microsoft Windows Portable Executable).

done.

[vcc, 2010-09-22 02:42:19]

Please take another look, thanks.

[rsc1, 2010-10-12 13:53:06]

please fix nit below and then hg sync; hg upload 1976045.
the current patch doesn't apply cleanly to the repository tip.

thanks very much.
russ

http://codereview.appspot.com/1976045/diff/24001/src/pkg/Makefile
File src/pkg/Makefile (right):

http://codereview.appspot.com/1976045/diff/24001/src/pkg/Makefile#newcode51
src/pkg/Makefile:51: debug/pe\
should sort above debug/proc

[vcc, 2010-10-12 14:41:25]

Thanks for review, please take another look.

http://codereview.appspot.com/1976045/diff/24001/src/pkg/Makefile
File src/pkg/Makefile (right):

http://codereview.appspot.com/1976045/diff/24001/src/pkg/Makefile#newcode51
src/pkg/Makefile:51: debug/pe\
On 2010/10/12 13:53:06, rsc1 wrote:
> should sort above debug/proc

Done.

[mattn, 2010-10-29 05:02:45]

On 2010/10/12 14:41:25, vcc wrote:
> Thanks for review, please take another look.
> 
> https://codereview.appspot.com/1976045/diff/24001/src/pkg/Makefile
> File src/pkg/Makefile (right):
> 
> https://codereview.appspot.com/1976045/diff/24001/src/pkg/Makefile#newcode51
> src/pkg/Makefile:51: debug/pe\
> On 2010/10/12 13:53:06, rsc1 wrote:
> > should sort above debug/proc
> 
> Done.

I tested this patch. And it's working good for me.
I notice cgocall isn't provided from this patch.
Is this another issue?

Thanks for you working.

[vcc, 2010-10-29 06:18:15]

2010/10/29 <mattn.jp@gmail.com>

> I tested this patch. And it's working good for me.
> I notice cgocall isn't provided from this patch.
> Is this another issue?
>
>
need another CL: http://codereview.appspot.com/2166041/ 8l : add dynimport
to import table in Windows PE, initi...<http://codereview.appspot.com/2166041/>



> Thanks for you working.
>
>
> https://codereview.appspot.com/1976045/
>

[rsc1, 2010-11-01 21:51:59]

LGTM

[rsc, 2010-11-01 21:52:31]

*** Submitted as 8affdb3ecf59 ***

debug/pe, cgo: add windows support

R=rsc, mattn
CC=golang-dev
http://codereview.appspot.com/1976045

Committer: Russ Cox <rsc@golang.org>