Issue 1975043: code review 1975043: os: implement env using native windows api.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1975043: code review 1975043: os: implement env using native windows api. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by brainman

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

os: implement env using native windows api. Fixes issue 864.

Patch Set 1 #

Patch Set 2 : code review 1975043: os: implement env using native windows api. #

Patch Set 3 : code review 1975043: os: implement env using native windows api. #

Patch Set 4 : code review 1975043: os: implement env using native windows api. #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -92 lines)			Patch
M	src/pkg/os/Makefile	View		1 chunk	+0 lines, -1 line	0 comments	Download
R	src/pkg/os/env.go	View		1 chunk	+0 lines, -87 lines	0 comments	Download
M	src/pkg/os/env_unix.go	View		1 chunk	+80 lines, -3 lines	0 comments	Download
M	src/pkg/os/env_windows.go	View	1	1 chunk	+91 lines, -0 lines	0 comments	Download
M	src/pkg/os/os_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View		2 chunks	+64 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows_386.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 9 months ago (2010-08-13 02:56:15 UTC) #1

brainman

14 years, 9 months ago (2010-08-13 04:29:30 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b447c44e3c2f ***

os: implement env using native windows api.
Fixes issue 864.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1975043

Expand All Messages | Collapse All Messages