Issue 197042: code review 197042: gc: add ... T, rework plain ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 197042: code review 197042: gc: add ... T, rework plain ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by rsc

Modified:
15 years, 7 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: add ... T, rework plain ... No longer a distinct type; now a property of func types.

Patch Set 1 #

Patch Set 2 : code review 197042: gc: rethinking of ... #

Patch Set 3 : code review 197042: gc: add ... T, rework plain ... #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+360 lines, -109 lines)			Patch
M	src/cmd/5g/gsubr.c	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/6g/gsubr.c	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/8g/gsubr.c	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/gc/align.c	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View	1 2	2 chunks	+14 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.h	View		5 chunks	+9 lines, -6 lines	0 comments	Download
M	src/cmd/gc/go.y	View	1 2	6 chunks	+35 lines, -14 lines	0 comments	Download
M	src/cmd/gc/print.c	View		2 chunks	+13 lines, -4 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1 2	8 chunks	+31 lines, -28 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 2	5 chunks	+23 lines, -12 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 2	4 chunks	+32 lines, -3 lines	0 comments	Download
M	src/pkg/exp/datafmt/datafmt.go	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/exp/eval/bridge.go	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	src/pkg/reflect/type.go	View		4 chunks	+16 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/type.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/type.go	View		3 chunks	+3 lines, -7 lines	0 comments	Download
A	test/ddd.go	View		1 chunk	+105 lines, -0 lines	0 comments	Download
A	test/ddd1.go	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	test/ddd2.go	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	test/ddd3.go	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 7 months ago (2010-02-01 08:25:57 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=21b009dab862 *** gc: add ... T, rework plain ... No longer a ...

15 years, 7 months ago (2010-02-01 08:26:02 UTC) #2

ken3

15 years, 7 months ago (2010-02-01 08:52:46 UTC) #3

LGTM

On 2010/02/01 08:26:02, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=21b009dab862 ***
> 
> gc: add ... T, rework plain ...
> 
> No longer a distinct type; now a property of func types.
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/197042

Expand All Messages | Collapse All Messages