code review 1962048: time.Parse should not require minutes for time zone

time.Parse should not require minutes for time zone
Fixes issue 1026.

[jhh, 2010-08-15 16:24:48]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-08-16 02:00:14]

Changes look reasonable but I wonder if there is a standard time
format we should include with the change.  How did this arise?

-rob

[jhh, 2010-08-17 15:47:38]

I have no idea; should I ask the issue reporter?

http://en.wikipedia.org/wiki/ISO_8601#Time_zone_designators
suggests "+-hh" is a common format.

On 2010/08/16 02:00:14, r2 wrote:
> Changes look reasonable but I wonder if there is a standard time
> format we should include with the change.  How did this arise?
> 
> -rob
>

[r, 2010-08-20 01:34:20]

looks good, but please tweak the test message. we don't use that quoting style

http://codereview.appspot.com/1962048/diff/2001/3002
File src/pkg/time/time_test.go (right):

http://codereview.appspot.com/1962048/diff/2001/3002#newcode172
src/pkg/time/time_test.go:172: ParseTest{"custom: `2006-01-02 15:04:05-07'",
"2006-01-02 15:04:05-07", "2010-02-04 21:00:57-08", true, false, 1},
i think the second single quote should be a double quote, or else just drop the
inner quotes altogether

[jhh, 2010-08-24 14:20:44]

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-08-24 21:40:36]

LGTM

[r, 2010-08-24 21:41:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=aba03c93af6a ***

time.Parse should not require minutes for time zone
Fixes issue 1026.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/1962048

Committer: Rob Pike <r@golang.org>