code review 1962042: gc: fix symbol table generation on windows

gc: fix symbol table generation on windows

gc records full, '/' delimited, filenames now.

[brainman, 2010-08-11 07:19:47]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-08-12 03:24:33]

LGTM

[brainman, 2010-08-12 03:38:27]

On 2010/08/12 03:24:33, rsc1 wrote:
> LGTM

Thank you for review.

One question. You would have noticed, unlike 8c, I've put full drive specifier,
like "c:/" (instead of just "/") in front of file names. I decided to do that,
as I've discovered, that 8l fails to link final binary in some situations (cd
$GOROOT/src/pkg/byte; make clean test). Shouldn't I apply same logic and change
8c to have "c:/" in front of all *.c file names?

Here is stack trace with c and go file listed to demonstrate:

U:\>test
panic: PANIC

panic PC=0x45b094
runtime.panic+0xa3 /TMP/go/src/pkg/runtime/proc.c:1012
       runtime.panic(0x0, 0x45b0c4)
main.main+0x43 U:/test.go:10
       main.main()
mainstart+0xf 386/asm.s:83
       mainstart()
goexit /TMP/go/src/pkg/runtime/proc.c:145
       goexit()

U:\>type test.go
// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// The bytes package implements functions for the manipulation of byte slices.
// Analogous to the facilities of the strings package.
package main

func main() {
       panic("PANIC")
}

U:\>

Here

runtime.panic+0xa3 /TMP/go/src/pkg/runtime/proc.c:1012

should be

runtime.panic+0xa3 c:/TMP/go/src/pkg/runtime/proc.c:1012

and

goexit /TMP/go/src/pkg/runtime/proc.c:145

should be

goexit c:/TMP/go/src/pkg/runtime/proc.c:145



Alex

[rsc, 2010-08-12 03:54:25]

i agree - c:/tmp is better.

On Wed, Aug 11, 2010 at 20:38,  <alex.brainman@gmail.com> wrote:
> On 2010/08/12 03:24:33, rsc1 wrote:
>>
>> LGTM
>
> Thank you for review.
>
> One question. You would have noticed, unlike 8c, I've put full drive
> specifier, like "c:/" (instead of just "/") in front of file names. I
> decided to do that, as I've discovered, that 8l fails to link final
> binary in some situations (cd $GOROOT/src/pkg/byte; make clean test).
> Shouldn't I apply same logic and change 8c to have "c:/" in front of all
> *.c file names?
>
> Here is stack trace with c and go file listed to demonstrate:
>
> U:\>test
> panic: PANIC
>
> panic PC=0x45b094
> runtime.panic+0xa3 /TMP/go/src/pkg/runtime/proc.c:1012
>       runtime.panic(0x0, 0x45b0c4)
> main.main+0x43 U:/test.go:10
>       main.main()
> mainstart+0xf 386/asm.s:83
>       mainstart()
> goexit /TMP/go/src/pkg/runtime/proc.c:145
>       goexit()
>
> U:\>type test.go
> // Copyright 2009 The Go Authors. All rights reserved.
> // Use of this source code is governed by a BSD-style
> // license that can be found in the LICENSE file.
>
> // The bytes package implements functions for the manipulation of byte
> slices.
> // Analogous to the facilities of the strings package.
> package main
>
> func main() {
>       panic("PANIC")
> }
>
> U:\>
>
> Here
>
> runtime.panic+0xa3 /TMP/go/src/pkg/runtime/proc.c:1012
>
> should be
>
> runtime.panic+0xa3 c:/TMP/go/src/pkg/runtime/proc.c:1012
>
> and
>
> goexit /TMP/go/src/pkg/runtime/proc.c:145
>
> should be
>
> goexit c:/TMP/go/src/pkg/runtime/proc.c:145
>
>
>
> Alex
>
> http://codereview.appspot.com/1962042/show
>

[brainman, 2010-09-07 06:40:55]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[brainman, 2010-09-07 06:41:05]

On 2010/08/12 03:54:25, rsc wrote:
> i agree - c:/tmp is better.
> 
> On Wed, Aug 11, 2010 at 20:38,  <mailto:alex.brainman@gmail.com> wrote:
> > Shouldn't I apply same logic and change 8c to have "c:/" in front of all
> > *.c file names?
> >

It looks like there is more that I could handle here <g>:

grep -r ^outhist $GOROOT/src/cmd

returns

/root/hg/go/src/cmd/5a/lex.c:outhist(void)
/root/hg/go/src/cmd/5c/swt.c:outhist(Biobuf *b)
/root/hg/go/src/cmd/6a/lex.c:outhist(void)
/root/hg/go/src/cmd/6c/swt.c:outhist(Biobuf *b)
/root/hg/go/src/cmd/8a/lex.c:outhist(void)
/root/hg/go/src/cmd/8c/swt.c:outhist(Biobuf *b)
/root/hg/go/src/cmd/gc/obj.c:outhist(Biobuf *b)

which lists 6 other programs besides gc, that I have changed. The final changes
are far from trivial, and I don't want introduce all these complications into 6
programs, unless we really need them.

Perhaps I will create an low priority "issue", so we remember?


Alex

[rsc, 2010-09-07 17:54:08]

On Tue, Sep 7, 2010 at 02:41,  <alex.brainman@gmail.com> wrote:
> On 2010/08/12 03:54:25, rsc wrote:
>>
>> i agree - c:/tmp is better.
>
>> On Wed, Aug 11, 2010 at 20:38,  <mailto:alex.brainman@gmail.com>
>
> wrote:
>>
>> > Shouldn't I apply same logic and change 8c to have "c:/" in front of
>
> all
>>
>> > *.c file names?
>> >
>
> It looks like there is more that I could handle here <g>:
>
> grep -r ^outhist $GOROOT/src/cmd
>
> returns
>
> /root/hg/go/src/cmd/5a/lex.c:outhist(void)
> /root/hg/go/src/cmd/5c/swt.c:outhist(Biobuf *b)
> /root/hg/go/src/cmd/6a/lex.c:outhist(void)
> /root/hg/go/src/cmd/6c/swt.c:outhist(Biobuf *b)
> /root/hg/go/src/cmd/8a/lex.c:outhist(void)
> /root/hg/go/src/cmd/8c/swt.c:outhist(Biobuf *b)
> /root/hg/go/src/cmd/gc/obj.c:outhist(Biobuf *b)
>
> which lists 6 other programs besides gc, that I have changed. The final
> changes are far from trivial, and I don't want introduce all these
> complications into 6 programs, unless we really need them.
>
> Perhaps I will create an low priority "issue", so we remember?

sure.  you can ignore 5a 5c 6a 6c for now if you want.

russ

[brainman, 2010-09-08 00:02:21]

On 2010/09/07 17:54:08, rsc wrote:
> sure.  you can ignore 5a 5c 6a 6c for now if you want.

Perhaps, I didn't make myself clear. I am proposing to submit changes to gc in
this CL. I will also create an issue to look into changing all a and c compilers
(8c, 8a, 6c, 6a, 5c and 5a) to generate windows file names in symbol table in a
similar way to gc. We have 6 copies of outhist() function, perhaps we can bring
it down to 1 or 2(c and a). All done at later time.


Alex

[rsc, 2010-09-08 00:12:27]

> Perhaps, I didn't make myself clear. I am proposing to submit changes to
> gc in this CL. I will also create an issue to look into changing all a
> and c compilers (8c, 8a, 6c, 6a, 5c and 5a) to generate windows file
> names in symbol table in a similar way to gc. We have 6 copies of
> outhist() function, perhaps we can bring it down to 1 or 2(c and a). All
> done at later time.

Works for me.

[brainman, 2010-09-08 00:28:44]

On 2010/09/08 00:12:27, rsc wrote:
> Works for me.

I'll wait for your review then <g>. Whenever you have time.

Alex

[brainman, 2010-09-12 02:23:03]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-09-12 03:24:34]

LGTM

[brainman, 2010-09-12 08:07:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=999a0b4b090e ***

gc: fix symbol table generation on windows

gc records full, '/' delimited, filenames now.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1962042

Committer: Alex Brainman <alex.brainman@gmail.com>