Issue 1962041: code review 1962041: fix build: update exp/draw/draw_test.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1962041: code review 1962041: fix build: update exp/draw/draw_test.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by gri

Modified:
15 years ago

Reviewers:
nigeltao

CC:
nigeltao_gnome, golang-dev

Visibility:
Public.

Description

fix build: update exp/draw/draw_test.go

Patch Set 1 #

Patch Set 2 : code review 1962041: fix build: update exp/draw/draw_test.go #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/exp/draw/draw_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello nigeltao (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-08-10 17:10:57 UTC) #1

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=3ae4ac9e899a *** fix build: update exp/draw/draw_test.go R=nigeltao CC=golang-dev http://codereview.appspot.com/1962041

15 years ago (2010-08-10 17:11:34 UTC) #2

nigeltao

15 years ago (2010-08-10 22:38:59 UTC) #3

On 2010/08/10 17:11:34, gri wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=3ae4ac9e899a ***
> 
> fix build: update exp/draw/draw_test.go
> 
> R=nigeltao
> CC=golang-dev
> http://codereview.appspot.com/1962041

Thanks -- I thought I ran make test, but I guess I didn't.

Expand All Messages | Collapse All Messages