Issue 196053: HttpResponse.getAndUpdateEncoding() barf with ArrayOutOfBoundsException upon empty header Content-Ty

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 196053: HttpResponse.getAndUpdateEncoding() barf with ArrayOutOfBoundsException upon empty header Content-Ty (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by mhermanto

Modified:
14 years, 6 months ago

Reviewers:
shindig.remailer, Jasvir

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

https://issues.apache.org/jira/browse/SHINDIG-1275

Patch Set 1 #

Total comments: 2

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java	View		1 chunk	+3 lines, -1 line	2 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Jasvir

http://codereview.appspot.com/196053/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java (right): http://codereview.appspot.com/196053/diff/1/3#newcode462 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java:462: || BINARY_CONTENT_TYPES.contains(parts[0])) { From rfc2616: The type, subtype, and ...

15 years, 7 months ago (2010-01-29 18:13:05 UTC) #2

Jasvir

ping. Has this been submitted? If so, can we close out this review.

15 years, 3 months ago (2010-06-04 19:05:21 UTC) #3

henry.saputra

Looks like no update on the svn diff based on your comment. - Henry

15 years, 3 months ago (2010-06-04 19:31:38 UTC) #4

plindner_linkedin.com

15 years, 3 months ago (2010-06-04 21:11:21 UTC) #5

patch was checked in:

commit e8b78142d5a712c875e4f9390b757eec1e39a6db
Author: Paul Lindner <lindner@apache.org>
Date:   Fri Jan 29 02:04:35 2010 +0000

    SHINDIG-1275 | Patch from Michael Hermanto |
HttpResponse.getAndUpdateEncoding() barf with ArrayOutOfBoundsException upon
empty header Content-Type

    git-svn-id:
https://svn.apache.org/repos/asf/incubator/shindig/trunk@90434113f79535-47bb-...



On Fri, Jun 4, 2010 at 12:05 PM, <jasvir@gmail.com> wrote:

> ping.  Has this been submitted?  If so, can we close out this review.
>
> http://codereview.appspot.com/196053/show
>

Expand All Messages | Collapse All Messages