Issue 1958048: code review 1958048: os: make return type of FileInfo.Permission() consisten...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1958048: code review 1958048: os: make return type of FileInfo.Permission() consisten... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by bytbox

Modified:
14 years, 8 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

os: make return type of FileInfo.Permission() consistent with related functions (uint32 rather than int)

Patch Set 1 #

Patch Set 2 : code review 1958048: os: make return type of FileInfo.Permission() consisten... #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/os/types.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bytbox

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-08-23 23:04:40 UTC) #1

If you make this change, does the entire repository compile without other edits? That is, ...

14 years, 8 months ago (2010-08-23 23:27:52 UTC) #2

bytbox

Yes. Amazingly. (For me. Linux jagadai 2.6.32-23-generic #37-Ubuntu SMP Fri Jun 11 08:03:28 UTC 2010 ...

14 years, 8 months ago (2010-08-24 00:12:01 UTC) #3

14 years, 8 months ago (2010-08-24 00:38:58 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=eb61291ced13 ***

os: make return type of FileInfo.Permission() consistent with related functions
(uint32 rather than int)

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/1958048

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages