Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 1957041: Output from mkall.sh (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by Ivan Krasin
Modified:
14 years, 11 months ago
Reviewers:
CC:
imkrasin, rsc, golang-dev
Visibility:
Public.

Description

Updated syscall/z* files with mkall.sh (386 and amd64 architectures) DISTRIB_DESCRIPTION="Ubuntu 10.04 LTS" Use <sys/user.h> instead of <linux/user.h> See http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00834.html for more details.

Patch Set 1 #

Patch Set 2 : code review 1957041: Output from mkall.sh #

Patch Set 3 : code review 1957041: Output from mkall.sh #

Patch Set 4 : code review 1957041: Output from mkall.sh #

Patch Set 5 : code review 1957041: Output from mkall.sh #

Patch Set 6 : code review 1957041: Output from mkall.sh #

Patch Set 7 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Patch Set 8 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Patch Set 9 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Patch Set 10 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Patch Set 11 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Patch Set 12 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Patch Set 13 : code review 1957041: Updated syscall/z* files with mkall.sh (386 and amd64 a... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -64 lines) Patch
M src/pkg/debug/proc/regs_linux_386.go View 2 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/syscall/syscall_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_linux.go View 8 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_linux_386.go View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/pkg/syscall/types_linux.c View 2 chunks +1 line, -1 line 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 17 chunks +36 lines, -2 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 18 chunks +39 lines, -3 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_amd64.go View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M src/pkg/syscall/zsysnum_linux_386.go View 1 chunk +13 lines, -3 lines 0 comments Download
M src/pkg/syscall/zsysnum_linux_amd64.go View 1 chunk +14 lines, -3 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_386.go View 3 chunks +7 lines, -13 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_amd64.go View 1 2 3 4 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 11
imkrasin
Russ, please, review these changes. I've updates syscall generated files for linux amd64/386.
14 years, 12 months ago (2010-08-10 19:32:20 UTC) #1
imkrasin
Hi Russ, these changes are blocking me from adding readv/writev, sendmsg/recvmsg to syscall package. It ...
14 years, 11 months ago (2010-08-11 20:09:57 UTC) #2
rsc
sorry i am in the middle of a 3500 mile move. i will try to ...
14 years, 11 months ago (2010-08-12 02:41:08 UTC) #3
imkrasin
On Thu, Aug 12, 2010 at 6:41 AM, Russ Cox <rsc@golang.org> wrote: > sorry i ...
14 years, 11 months ago (2010-08-12 05:20:53 UTC) #4
imkrasin
Extremely friendly ping. Valid only if you've completed the move. On 2010/08/12 05:20:53, imkrasin wrote: ...
14 years, 11 months ago (2010-08-20 12:17:32 UTC) #5
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=031f3b3c7b63 *** syscall: regenerate syscall/z* files for linux/386, linux/amd64 DISTRIB_DESCRIPTION="Ubuntu 10.04 LTS" ...
14 years, 11 months ago (2010-08-20 13:12:30 UTC) #6
rsc
LGTM why the change to socketpair? it's fine, i'm just curious. russ
14 years, 11 months ago (2010-08-20 13:15:33 UTC) #7
Ivan Krasin
*** Abandoned ***
14 years, 11 months ago (2010-08-20 13:20:55 UTC) #8
gri1
This change broke the build: http://godashboard.appspot.com/?n=30&p=1 - gri On Fri, Aug 20, 2010 at 6:12 ...
14 years, 11 months ago (2010-08-20 17:07:40 UTC) #9
imkrasin
On Fri, Aug 20, 2010 at 9:07 PM, Robert Griesemer <gri@google.com> wrote: > This change ...
14 years, 11 months ago (2010-08-20 17:11:41 UTC) #10
rsc
14 years, 11 months ago (2010-08-20 17:54:48 UTC) #11
Not able to make changes now.  Will revert in an hour or so unless someone
beats me to it.  There's no HG command to automate the rollback with
codereview sorry

Russ

(sent from my phone - sorry for the bad formatting)

On Aug 20, 2010 1:11 PM, "Ivan Krasin" <imkrasin@gmail.com> wrote:
> On Fri, Aug 20, 2010 at 9:07 PM, Robert Griesemer <gri@google.com> wrote:
>> This change broke the build: http://godashboard.appspot.com/?n=30&p=1
> My apologies. Please, revert my CL.
>
>
>
>> - gri
>>
>> On Fri, Aug 20, 2010 at 6:12 AM, <rsc@golang.org> wrote:
>>>
>>> *** Submitted as
>>> http://code.google.com/p/go/source/detail?r=031f3b3c7b63 ***
>>>
>>> syscall: regenerate syscall/z* files for linux/386, linux/amd64
>>> DISTRIB_DESCRIPTION="Ubuntu 10.04 LTS"
>>>
>>> Use <sys/user.h> instead of <linux/user.h>
>>> See http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00834.html for more
>>> details.
>>>
>>> R=imkrasin, rsc
>>> CC=golang-dev
>>> http://codereview.appspot.com/1957041
>>>
>>> Committer: Russ Cox <rsc@golang.org>
>>>
>>>
>>> http://codereview.appspot.com/1957041/
>>
>>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b