code review 1954049: Fixes for generating proper file:line debug info for .g...

runtime: correct line numbers for .goc files.
Linenumbers start at 1.
Also call goc2c with an absolute pathi to preserve debug info.

[lvd, 2010-08-17 11:09:40]

Hello ken2, r2, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-08-17 16:11:41]

Looks good but please change the CL description
to have the form 

packagename: very short summary
Explanatory text if necessary.

as described in http://golang.org/doc/contribute.html.
(Various programs expect this form, like the one
that generates the draft release notes.)

In this case

runtime: correct line numbers for .goc files

would be a good first line.  Thanks.

[lvd, 2010-08-17 16:32:46]

On 2010/08/17 16:11:41, rsc1 wrote:
> Looks good but please change the CL description
> to have the form 
> 
> packagename: very short summary
> Explanatory text if necessary.
> 
> as described in http://golang.org/doc/contribute.html.
> (Various programs expect this form, like the one
> that generates the draft release notes.)
> 
> In this case
> 
> runtime: correct line numbers for .goc files
> 
> would be a good first line.  Thanks.

done.

[rsc, 2010-08-17 17:22:47]

LGTM

After you review and I submit 1956046,
use this CL as a test to get hg submit
working on your machine.

[lvd, 2010-08-17 21:58:35]

that Nearly Worked.

lvd@hpgntai-ubiq89:~/g/src$ hg submit 1954049
http authorization required
realm: Google Code Mercurial Repository
user: lvd@golang.org
password:
abort: authorization failed
lvd@hpgntai-ubiq89:~/g/src$ hg submit 1954049
http authorization required
realm: Google Code Mercurial Repository
user: lvd@google.com
password:
abort: authorization failed
lvd@hpgntai-ubiq89:~/g/src$ hg submit 1954049
http authorization required
realm: Google Code Mercurial Repository
user: lvd
password:
abort: authorization failed


hmmm..  who am i?


On Tue, Aug 17, 2010 at 19:22, Russ Cox <rsc@golang.org> wrote:

> LGTM
>
> After you review and I submit 1956046,
> use this CL as a test to get hg submit
> working on your machine.
>

[rsc, 2010-08-17 22:03:24]

something went wrong following the instructions at
http://www/~rsc/gohg.html

you should not get that kind of password prompt
assuming that either $HOME/.hgrc or $GOROOT/.hg/hgrc
has info like:

[auth]
go.username = lvd@golang.org
go.password = randomtextfromgooglecode
go.prefix = go.googlecode.com/

you might go back to your code.google.com
settings as lvd@golang.org and make sure the randomtext
matches what they have.

russ

[lvd, 2010-08-17 22:04:20]

On Wed, Aug 18, 2010 at 00:03, Russ Cox <rsc@golang.org> wrote:

> something went wrong following the instructions at
> http://www/~rsc/gohg.html


yes.  i forgot to read them. sorry.


>
>
> you should not get that kind of password prompt
> assuming that either $HOME/.hgrc or $GOROOT/.hg/hgrc
> has info like:
>
> [auth]
> go.username = lvd@golang.org
> go.password = randomtextfromgooglecode
> go.prefix = go.googlecode.com/
>
> you might go back to your code.google.com
> settings as lvd@golang.org and make sure the randomtext
> matches what they have.
>
> russ
>

[lvd, 2010-08-17 22:16:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=a70c1076ec2e ***

runtime: correct line numbers for .goc files.
Linenumbers start at 1.
Also call goc2c with an absolute pathi to preserve debug info.

R=rsc, r, ken2
CC=golang-dev
http://codereview.appspot.com/1954049