Issue 1947042: code review 1947042: exp/draw: remove the Color, Point and Rectangle types.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1947042: code review 1947042: exp/draw: remove the Color, Point and Rectangle types. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by nigeltao

Modified:
15 years, 1 month ago

Reviewers:
peterGo

CC:
r, golang-dev

Visibility:
Public.

Description

exp/draw: remove the Color, Point and Rectangle types. image: introduce Transparent and Opaque.

Patch Set 1 #

Patch Set 2 : code review 1947042: exp/draw: remove the Color, Point and Rectangle types. #

Patch Set 3 : code review 1947042: exp/draw: remove the Color, Point and Rectangle types. #

Patch Set 4 : code review 1947042: exp/draw: remove the Color, Point and Rectangle types. #

Patch Set 5 : code review 1947042: exp/draw: remove the Color, Point and Rectangle types. #

Patch Set 6 : code review 1947042: exp/draw: remove the Color, Point and Rectangle types. #

Patch Set 7 : code review 1947042: exp/draw: remove the Color, Point and Rectangle types. #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -354 lines)			Patch
M	src/pkg/exp/4s/data.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/4s/xs.go	View		22 chunks	+72 lines, -70 lines	0 comments	Download
M	src/pkg/exp/draw/Makefile	View		1 chunk	+0 lines, -2 lines	0 comments	Download
R	src/pkg/exp/draw/arith.go	View		1 chunk	+0 lines, -155 lines	0 comments	Download
R	src/pkg/exp/draw/color.go	View	1 2 3 4 5 6	1 chunk	+0 lines, -103 lines	0 comments	Download
M	src/pkg/exp/draw/draw.go	View		8 chunks	+18 lines, -18 lines	0 comments	Download
M	src/pkg/exp/draw/event.go	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/pkg/image/names.go	View	1 2 3 4 5	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-08-10 07:52:59 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=427d175b21e4 *** exp/draw: remove the Color, Point and Rectangle types. image: introduce ...

15 years, 1 month ago (2010-08-10 12:05:18 UTC) #3

peterGo

15 years, 1 month ago (2010-08-10 15:17:32 UTC) #4

On 2010/08/10 12:05:18, nigeltao_golang wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=427d175b21e4 ***
> 
> exp/draw: remove the Color, Point and Rectangle types.
> image: introduce Transparent and Opaque.
> 
> R=r
> CC=golang-dev
> http://codereview.appspot.com/1947042

GOOS=linux, GOARCH=amd64, hg id 427d175b21e4+ tip.

cd exp/draw && /home/peter/go/bin/gomake test
make[1]: Entering directory `/home/peter/go/src/pkg/exp/draw'
/home/peter/go/bin/gotest
make[2]: Entering directory `/home/peter/go/src/pkg/exp/draw'
rm -f _test/exp/draw.a _gotest_.6
make[2]: Leaving directory `/home/peter/go/src/pkg/exp/draw'
make[2]: Entering directory `/home/peter/go/src/pkg/exp/draw'
/home/peter/go/bin/6g -o _gotest_.6 draw.go event.go  draw_test.go
draw_test.go:140: undefined: Rect
draw_test.go:140: undefined: ZP
draw_test.go:167: undefined: Rect
draw_test.go:167: undefined: Pt
make[2]: *** [_gotest_.6] Error 1
make[2]: Leaving directory `/home/peter/go/src/pkg/exp/draw'
make[1]: *** [test] Error 2
make[1]: Leaving directory `/home/peter/go/src/pkg/exp/draw'
make: *** [exp/draw.test] Error 2

Expand All Messages | Collapse All Messages