code review 1943049: libmach: implement register fetch for 32-bit x86 kernel

libmach: implement register fetch for 32-bit x86 kernel
Also use memmove to silence some gcc warnings.

Fixes issue 1036.

[rsc, 2010-08-20 13:39:55]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[EtherealMachine, 2010-08-20 15:47:15]

On 2010/08/20 13:39:55, rsc wrote:
> Hello r (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change.

After patch, 6prof worked for me, with all options tested.

GOARCH=386
GOOS=linux
Linux 2.6.32-24, compiled for i636

[r, 2010-08-20 21:35:43]

LGTM

[rsc, 2010-08-21 00:49:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=7824ecf15ba9 ***

libmach: implement register fetch for 32-bit x86 kernel
Also use memmove to silence some gcc warnings.

Fixes issue 1036.

R=r, EtherealMachine
CC=golang-dev
http://codereview.appspot.com/1943049

[iant2, 2010-08-21 00:53:34]

rsc@golang.org writes:

> Also use memmove to silence some gcc warnings.

Why not memcpy?

Ian

[r, 2010-08-21 00:55:08]

Why not memmove, which is never incorrect?

-rob

[iant2, 2010-08-21 00:57:57]

"Rob 'Commander' Pike" <r@golang.org> writes:

> Why not memmove, which is never incorrect?

Just efficiency.  They are both implemented directly by the compiler,
and the compiler can do better with memcpy in cases where it can not
prove that the addresses do not overlap.

memmove is fine.

Ian