Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 194129: code review 194129: gc: tweak error messages, avoid internalization setting... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by rsc
Modified:
15 years, 2 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

gc: tweak error messages, avoid internalization settings in bison

Patch Set 1 #

Patch Set 2 : code review 194129: gc: tweak error messages, avoid internalization setting... #

Patch Set 3 : code review 194129: gc: tweak error messages, avoid internalization setting... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M src/cmd/gc/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/go.errors View 1 chunk +8 lines, -8 lines 0 comments Download
M src/cmd/gc/lex.c View 2 chunks +13 lines, -9 lines 0 comments Download
M test/syntax/import.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi1.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi2.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi3.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi4.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi5.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi6.go View 1 chunk +1 line, -1 line 0 comments Download
M test/syntax/semi7.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 2 months ago (2010-01-28 20:57:32 UTC) #1
r2
LGTM On 29/01/2010, at 7:57 AM, rsc@golang.org wrote: > Reviewers: r, > > Message: > ...
15 years, 2 months ago (2010-01-28 21:03:42 UTC) #2
rsc
15 years, 2 months ago (2010-01-28 23:57:50 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f608d0a8776b ***

gc: tweak error messages, avoid internalization settings in bison

R=r
CC=golang-dev
http://codereview.appspot.com/194129
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b