Issue 194116: code review 194116: dashboard: builder tweaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194116: code review 194116: dashboard: builder tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Patch Set 2 : code review 194116: dashboard: builder tweaks #

Patch Set 3 : code review 194116: dashboard: builder tweaks #

Total comments: 2

Patch Set 4 : code review 194116: dashboard: builder tweaks #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -17 lines)			Patch
M	misc/dashboard/README	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	misc/dashboard/buildcontrol.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	misc/dashboard/buildcron.sh	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
M	misc/dashboard/builder.sh	View		1 chunk	+15 lines, -7 lines	0 comments	Download
M	misc/dashboard/godashboard/gobuild.py	View		3 chunks	+33 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 3 months ago (2010-01-27 23:15:53 UTC) #1

agl1

LGTM http://codereview.appspot.com/194116/diff/19/1010 File misc/dashboard/godashboard/gobuild.py (right): http://codereview.appspot.com/194116/diff/19/1010#newcode123 misc/dashboard/godashboard/gobuild.py:123: recent = q.fetch(N+1) (unimportant) you actually only need ...

15 years, 3 months ago (2010-01-27 23:38:25 UTC) #2

rsc

> http://codereview.appspot.com/194116/diff/19/1010#newcode123 > misc/dashboard/godashboard/gobuild.py:123: recent = q.fetch(N+1) > (unimportant) you actually only need to fetch ...

15 years, 3 months ago (2010-01-27 23:41:26 UTC) #3

rsc

15 years, 3 months ago (2010-01-27 23:42:39 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=190a6b47b46e ***

dashboard: builder tweaks

R=agl1
CC=golang-dev
http://codereview.appspot.com/194116

Expand All Messages | Collapse All Messages