Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(548)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1941042: code review 1941042: Small performance improvements to the HTML tokenizer ba... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by Kyle C
Modified:
14 years, 9 months ago
Reviewers:
CC:
nigeltao, golang-dev
Visibility:
Public.

Description

Small performance improvements to the HTML tokenizer based on your 'TODO's.

Patch Set 1 #

Patch Set 2 : code review 1941042: Small performance improvements to the HTML tokenizer ba... #

Patch Set 3 : code review 1941042: Small performance improvements to the HTML tokenizer ba... #

Total comments: 6

Patch Set 4 : code review 1941042: Small performance improvements to the HTML tokenizer ba... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M src/pkg/html/escape.go View 1 2 3 2 chunks +35 lines, -7 lines 0 comments Download
M src/pkg/html/token.go View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6
Kyle C
Hello nigeltao_golang (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-08-10 23:31:32 UTC) #1
nigeltao
http://codereview.appspot.com/1941042/diff/6001/7001 File src/pkg/html/escape.go (right): http://codereview.appspot.com/1941042/diff/6001/7001#newcode66 src/pkg/html/escape.go:66: func escapeStringTo(buf *bytes.Buffer, s string) { I'd s/escapeStringTo/escape/ for ...
14 years, 10 months ago (2010-08-11 12:59:55 UTC) #2
Kyle C
http://codereview.appspot.com/1941042/diff/6001/7001 File src/pkg/html/escape.go (right): http://codereview.appspot.com/1941042/diff/6001/7001#newcode66 src/pkg/html/escape.go:66: func escapeStringTo(buf *bytes.Buffer, s string) { On 2010/08/11 12:59:55, ...
14 years, 9 months ago (2010-08-11 15:38:35 UTC) #3
Kyle C
Hello nigeltao_golang (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 9 months ago (2010-08-11 15:38:51 UTC) #4
nigeltao_gnome
LGTM.
14 years, 9 months ago (2010-08-11 23:45:39 UTC) #5
nigeltao
14 years, 9 months ago (2010-08-11 23:45:52 UTC) #6 
*** Submitted as http://code.google.com/p/go/source/detail?r=a6041917aabd ***

Small performance improvements to the HTML tokenizer based on your 'TODO's.

R=nigeltao_golang
CC=golang-dev
http://codereview.appspot.com/1941042

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b