Issue 194092: code review 194092: godashboard: fiddling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194092: code review 194092: godashboard: fiddling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

godashboard: fiddling * some tweaks to dashboard html/css layout * use hmac to generate per-builder subkeys

Patch Set 2 : code review 194092: godashboard: fiddling #

Patch Set 3 : code review 194092: godashboard: fiddling #

Total comments: 1

Patch Set 4 : code review 194092: godashboard: fiddling #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -31 lines)			Patch
	M	misc/dashboard/godashboard/gobuild.py	View	1 2 3	7 chunks	+23 lines, -10 lines	0 comments	Download
	M	misc/dashboard/godashboard/main.html	View	1 2 3	3 chunks	+36 lines, -21 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello agl, agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 4 months ago (2010-01-26 23:02:29 UTC) #1

rsc

btw, ui tweaks live at http://rsc.latest.godashboard.appspot.com/

15 years, 4 months ago (2010-01-26 23:12:56 UTC) #3

agl1

LGTM http://codereview.appspot.com/194092/diff/1011/1012 File misc/dashboard/godashboard/gobuild.py (right): http://codereview.appspot.com/194092/diff/1011/1012#newcode75 misc/dashboard/godashboard/gobuild.py:75: builders = {} (unimportant) Seems that you could ...

15 years, 4 months ago (2010-01-27 07:42:01 UTC) #4

rsc

15 years, 4 months ago (2010-01-27 21:10:02 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=cfe5fdc59ce2 ***

godashboard: fiddling
  * some tweaks to dashboard html/css layout
  * use hmac to generate per-builder subkeys

R=agl1
CC=golang-dev
http://codereview.appspot.com/194092

Expand All Messages | Collapse All Messages