code review 194084: Cosmetic bug or compliance fixes in http.Response.

Cosmetic bug or compliance fixes in http.Response.

(1) http.Response must close resp.Body after writing.
(2) Case when resp.Body != nil and resp.ContentLength = 0 should not be
treated as an error in Response.Write, because this is what
ReadResponse often returns.
(3) Changed body.th to body.hdr for readability.

[petar-m, 2010-01-26 18:25:40]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-26 20:55:25]

Thanks.

I tried to patch this in but had to tweak request.go
to say hdr: instead of th:, and even then the test failed:

--- FAIL: http.TestReadResponse
	#0: Body = "" want "Body here\n"
FAIL

[petar_csail.mit.edu, 2010-01-27 01:41:17]

Do you want me to take some action? That doesn't look like a review.

--P


On Tue, Jan 26, 2010 at 3:55 PM,  <rsc@golang.org> wrote:
> Thanks.
>
> I tried to patch this in but had to tweak request.go
> to say hdr: instead of th:, and even then the test failed:
>
> --- FAIL: http.TestReadResponse
>        #0: Body = "" want "Body here\n"
> FAIL
>
>
>
> http://codereview.appspot.com/194084/show
>

[rsc, 2010-01-27 01:47:42]

On Tue, Jan 26, 2010 at 17:41, Petar Maymounkov <petar@csail.mit.edu> wrote:
> Do you want me to take some action? That doesn't look like a review.

yes: please update the CL so that it compiles and passes the tests.  ;-)

thanks.

[petar_csail.mit.edu, 2010-01-27 16:07:11]

Done.

On Tue, Jan 26, 2010 at 8:47 PM, Russ Cox <rsc@golang.org> wrote:
> On Tue, Jan 26, 2010 at 17:41, Petar Maymounkov <petar@csail.mit.edu> wrote:
>> Do you want me to take some action? That doesn't look like a review.
>
> yes: please update the CL so that it compiles and passes the tests.  ;-)
>
> thanks.
>

[rsc, 2010-01-28 23:13:30]

*** Submitted as http://code.google.com/p/go/source/detail?r=02ce85717639 ***

Cosmetic bug or compliance fixes in http.Response.

(1) http.Response must close resp.Body after writing.
(2) Case when resp.Body != nil and resp.ContentLength = 0 should not be
treated as an error in Response.Write, because this is what
ReadResponse often returns.
(3) Changed body.th to body.hdr for readability.

R=rsc
CC=golang-dev
http://codereview.appspot.com/194084

Committer: Russ Cox <rsc@golang.org>

[rsc1, 2010-01-28 23:13:37]

LGTM