Issue 194076: code review 194076: salvaging 183105 from dead client

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194076: code review 194076: salvaging 183105 from dead client (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by kaib

Modified:
15 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

salvaging 183105 from dead client a number of fixes for arm elf generation in 5l. -T now works as advertised, -D now works properly.

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	src/cmd/5l/asm.c	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/cmd/5l/doc.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/5l/obj.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3

kaib

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 6 months ago (2010-01-26 05:38:11 UTC) #1

kaib

*** Submitted as http://code.google.com/p/go/source/detail?r=d0805b70b30a *** salvaging 183105 from dead client a number of fixes for ...

15 years, 6 months ago (2010-01-26 05:40:15 UTC) #2

LGTM