Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(315)

Issue 194046: code review 194046: Cosmetic changes to make Request.Body an io.ReadCloser,... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by petar-m
Modified:
15 years, 9 months ago
Reviewers:
CC:
rsc, rsc1, golang-dev
Visibility:
Public.

Description

Cosmetic changes to make Request.Body an io.ReadCloser, to match Response.Body.

Patch Set 1 #

Patch Set 2 : code review 194046: Cosmetic changes to make Request.Body an io.ReadCloser,... #

Total comments: 4

Patch Set 3 : code review 194046: Cosmetic changes to make Request.Body an io.ReadCloser,... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M src/pkg/http/client.go View 2 chunks +7 lines, -1 line 0 comments Download
M src/pkg/http/request.go View 1 2 4 chunks +7 lines, -10 lines 0 comments Download
M src/pkg/http/request_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/response.go View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
petar-m
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 9 months ago (2010-01-24 17:42:54 UTC) #1
rsc1
looks good, two small comments. thanks. http://codereview.appspot.com/194046/diff/1001/1003 File src/pkg/http/request.go (right): http://codereview.appspot.com/194046/diff/1001/1003#newcode138 src/pkg/http/request.go:138: // If Body ...
15 years, 9 months ago (2010-01-25 21:58:29 UTC) #2
petar-m
Done. http://codereview.appspot.com/194046/diff/1001/1003 File src/pkg/http/request.go (right): http://codereview.appspot.com/194046/diff/1001/1003#newcode138 src/pkg/http/request.go:138: // If Body is present, "Transfer-Encoding: chunked" is ...
15 years, 9 months ago (2010-01-26 02:42:07 UTC) #3
rsc1
LGTM thanks
15 years, 9 months ago (2010-01-26 02:44:46 UTC) #4
rsc
15 years, 9 months ago (2010-01-26 02:49:10 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=3985265e8150 ***

http: make Request.Body an io.ReadCloser, matching Response.Body.

R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/194046

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b