Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(556)

Issue 1939044: bytes.Buffer: add Seek, WriteAt, ReadAt, Close, and Closed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by bytbox
Modified:
13 years, 7 months ago
Reviewers:
CC:
golang-dev
Visibility:
Public.

Description

bytes.Buffer: add Seek, WriteAt, ReadAt, Close, and Closed Fixes issue 440. Background: makes bytes.Buffer API more consistent with os.File https://groups.google.com/group/golang-nuts/browse_thread/thread/1eaded9352517dbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -4 lines) Patch
M src/pkg/bytes/buffer.go View 14 chunks +87 lines, -3 lines 0 comments Download
M src/pkg/bytes/buffer_test.go View 2 chunks +53 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc1
Saw this in the list. Maybe you're not ready for review but I want to ...
15 years ago (2010-08-26 15:16:41 UTC) #1
bytbox
On 8/26/10, rsc@google.com <rsc@google.com> wrote: > Saw this in the list. Maybe you're not ready ...
15 years ago (2010-08-26 15:27:07 UTC) #2
rsc
> I did not see that - I was lifting code from the patch provided ...
15 years ago (2010-08-26 15:30:19 UTC) #3
rsc1
removing reviewers
15 years ago (2010-08-30 19:45:53 UTC) #4
bytbox
15 years ago (2010-08-31 22:17:05 UTC) #5
This is a test. If by some great chance it goes through, rather than 500'ing,
please ignore it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b