Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(435)

Issue 179074: code review 179074: A stringio for Go. Seems making sense to have it includ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by i3d
Modified:
15 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

A stringio for Go. Seems making sense to have it included in the io package. Please take a look.

Patch Set 1 #

Patch Set 2 : code review 179074: A stringio for Go. Seems making sense to have it includ... #

Patch Set 3 : code review 179074: A stringio for Go. Seems making sense to have it includ... #

Patch Set 4 : code review 179074: A stringio for Go. Seems making sense to have it includ... #

Total comments: 19
Unified diffs Side-by-side diffs Delta from patch set Stats (+503 lines, -0 lines) Patch
M src/pkg/io/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/io/stringio.go View 1 1 chunk +225 lines, -0 lines 19 comments Download
A src/pkg/io/stringio_test.go View 1 2 3 1 chunk +277 lines, -0 lines 0 comments Download

Messages

Total messages: 7
i3d
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 8 months ago (2009-12-16 05:47:18 UTC) #1
rsc
Thanks for taking the time to send this in. This doesn't belong in io, which ...
15 years, 8 months ago (2009-12-16 08:31:52 UTC) #2
i3d
Hi Russ, Thanks for the comments! Since I've also post this idea into the group ...
15 years, 8 months ago (2009-12-17 05:30:23 UTC) #3
i3d
Any updates Russ? Should it be a separate module or should I just extend Buffer? ...
15 years, 8 months ago (2009-12-21 00:06:54 UTC) #4
rsc
On Sun, Dec 20, 2009 at 16:06, <i3dmaster@gmail.com> wrote: > Any updates Russ? Should it ...
15 years, 8 months ago (2009-12-21 15:21:40 UTC) #5
i3d
Ok I see. Sure, we can talk about this after the holiday. In general, this ...
15 years, 8 months ago (2009-12-21 19:42:54 UTC) #6
i3d
15 years, 8 months ago (2010-01-05 05:02:11 UTC) #7
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b