Issue 1939042: code review 1939042: math: amd64 version of Sincos

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1939042: code review 1939042: math: amd64 version of Sincos (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Charlie Dorian

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Patch Set 2 : code review 1939042: math: amd64 version of Sincos #

Total comments: 1

Patch Set 3 : code review 1939042: math: amd64 version of Sincos #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -0 lines)			Patch
	M	src/pkg/math/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	src/pkg/math/sincos_amd64.s	View	1 2	1 chunk	+143 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-08-19 17:38:02 UTC) #1

rsc1

LGTM but please add the comment http://codereview.appspot.com/1939042/diff/2001/3002 File src/pkg/math/sincos_amd64.s (right): http://codereview.appspot.com/1939042/diff/2001/3002#newcode16 src/pkg/math/sincos_amd64.s:16: // This code ...

14 years, 8 months ago (2010-08-26 14:46:12 UTC) #2

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 8 months ago (2010-08-26 22:09:34 UTC) #3

Charlie Dorian

Thanks for the review. On Thu, Aug 26, 2010 at 10:46 AM, <rsc@google.com> wrote: > ...

14 years, 8 months ago (2010-08-26 22:10:30 UTC) #4

rsc

14 years, 8 months ago (2010-08-26 23:04:00 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=302272adbd53 ***

math: amd64 version of Sincos

R=rsc
CC=golang-dev
http://codereview.appspot.com/1939042

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages