Issue 1917044: code review 1917044: crypto/x509: unwrap Subject Key Identifier

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1917044: code review 1917044: crypto/x509: unwrap Subject Key Identifier (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by agl1

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

crypto/x509: unwrap Subject Key Identifier RFC 5280, 4.2.1.2 says: SubjectKeyIdentifier ::= KeyIdentifier KeyIdentifier ::= OCTET STRING Previously, we were failing to unwrap the second level of OCTET STRING encoding. Fixes issue 993.

Patch Set 1 #

Patch Set 2 : code review 1917044: crypto/x509: unwrap Subject Key Identifier #

Patch Set 3 : code review 1917044: crypto/x509: unwrap Subject Key Identifier #

Patch Set 4 : code review 1917044: crypto/x509: unwrap Subject Key Identifier #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-08-03 16:26:47 UTC) #3

agl1

15 years ago (2010-08-03 16:26:53 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=302e6a62c1b7 ***

crypto/x509: unwrap Subject Key Identifier

RFC 5280, 4.2.1.2 says:
  SubjectKeyIdentifier ::= KeyIdentifier
  KeyIdentifier ::= OCTET STRING

Previously, we were failing to unwrap the second level of OCTET STRING
encoding.

Fixes issue 993.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1917044

Expand All Messages | Collapse All Messages